From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45629) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJIby-0004Zu-JD for qemu-devel@nongnu.org; Tue, 10 Sep 2013 03:43:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VJIbs-0004k6-G5 for qemu-devel@nongnu.org; Tue, 10 Sep 2013 03:43:46 -0400 Message-ID: <522ECDA2.9060602@redhat.com> Date: Tue, 10 Sep 2013 09:43:30 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1378247351-8446-1-git-send-email-hpoussin@reactos.org> <1378247351-8446-6-git-send-email-hpoussin@reactos.org> <5226CCD4.2030204@redhat.com> <5226EB43.203@redhat.com> <522E362B.4030208@reactos.org> In-Reply-To: <522E362B.4030208@reactos.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 05/10] raven: set a correct PCI I/O memory region List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= Cc: Peter Maydell , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , "qemu-ppc@nongnu.org" , QEMU Developers Il 09/09/2013 22:57, Herv=C3=A9 Poussineau ha scritto: >> >=20 > Paolo, Peter, so, did we raise some consensus? Should I reuse > get_system_io(), or having a separate MemoryRegion is acceptable? > I think that creating a independant MemoryRegion is better, as I see no > reason why QEMU should provide a global I/O region, which has some sens= e > mostly on x86 architectures only. > However, I can rework patches to use get_system_io() if that's what you > prefer... Since alpha-softmmu and versatile have established a precedent, your patch is fine. Thanks! Paolo