From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50724) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJNbI-0005b7-2S for qemu-devel@nongnu.org; Tue, 10 Sep 2013 09:03:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VJNbC-00056m-2p for qemu-devel@nongnu.org; Tue, 10 Sep 2013 09:03:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23205) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJNbB-00056Q-QX for qemu-devel@nongnu.org; Tue, 10 Sep 2013 09:03:17 -0400 Message-ID: <522F188B.7040808@redhat.com> Date: Tue, 10 Sep 2013 15:03:07 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1378784607-7398-1-git-send-email-junqing.wang@cs2c.com.cn> <1378784607-7398-3-git-send-email-junqing.wang@cs2c.com.cn> <87eh8weq48.fsf@elfo.elfo> In-Reply-To: <87eh8weq48.fsf@elfo.elfo> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC 2/4] Curling: cmdline interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: quintela@redhat.com Cc: stefanha@redhat.com, owasserm@redhat.com, Jules Wang , qemu-devel@nongnu.org Il 10/09/2013 15:57, Juan Quintela ha scritto: >> > >> > + if (strstart(uri, "curling:", &p)) { >> > + ft_mode = true; >> > + uri = p; >> > + } >> > + > Syntax is at least weird: > > curling:tcp:foo:9999 > > curling+tcp:foo:9999 > > could be better? Suggestions folks? > > notice that we still need more things: tcp+tls should happen at some > time soon. This is not related with this patch. > I think for the outgoing side it should just be "migrate -f tcp:foo:9999". On the incoming side, perhaps you could have a different ID instead of QEMU_VM_FILE_MAGIC, that triggers fault-tolerance mode automatically? Then again it would be simply "-incoming tcp:foo:9999". Paolo