From: Paolo Bonzini <pbonzini@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: peter.maydell@linaro.org, mjt@tls.msk.ru, qemu-devel@nongnu.org,
stefanha@redhat.com, vilanova@ac.upc.edu, rth@twiddle.net
Subject: Re: [Qemu-devel] [RFC PATCH v4 5/6] configure: introduce --enable-modules
Date: Tue, 10 Sep 2013 15:42:16 +0200 [thread overview]
Message-ID: <522F21B8.80505@redhat.com> (raw)
In-Reply-To: <1378818985-12584-6-git-send-email-famz@redhat.com>
Il 10/09/2013 15:16, Fam Zheng ha scritto:
> +ifeq ($(CONFIG_MODULES),y)
> define add-modules
> $(foreach o,$(filter %.o,$($1)),$(eval \
> $(patsubst %.o,%.mo,$o): $o))
> @@ -146,6 +147,13 @@ dummy := $(call add-modules,common-obj-m)
>
> modules: $(patsubst %.mo,%$(DSOSUF),$(modules-m))
> all: modules
> +else
> +block-obj-y += $(block-obj-m)
> +common-obj-y += $(common-obj-m)
> +block-obj-m :=
> +common-obj-m :=
> +endif
> +
Should this be done in unnest-vars instead?
Paolo
next prev parent reply other threads:[~2013-09-10 13:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 13:16 [Qemu-devel] [RFC PATCH v4 0/6] Shared Library Module Support Fam Zheng
2013-09-10 13:16 ` [Qemu-devel] [RFC PATCH v4 1/6] make.rule: fix $(obj) to a real relative path Fam Zheng
2013-09-10 13:16 ` [Qemu-devel] [RFC PATCH v4 2/6] rule.mak: allow per object cflags and libs Fam Zheng
2013-09-10 13:16 ` [Qemu-devel] [RFC PATCH v4 3/6] Makefile: introduce common-obj-m and block-obj-m for DSO Fam Zheng
2013-09-10 13:44 ` Paolo Bonzini
2013-09-11 1:14 ` Fam Zheng
2013-09-10 13:16 ` [Qemu-devel] [RFC PATCH v4 4/6] module: implement module loading function Fam Zheng
2013-09-10 13:16 ` [Qemu-devel] [RFC PATCH v4 5/6] configure: introduce --enable-modules Fam Zheng
2013-09-10 13:42 ` Paolo Bonzini [this message]
2013-09-10 13:16 ` [Qemu-devel] [RFC PATCH v4 6/6] block: build qed and curl as shared library Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522F21B8.80505@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).