From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60829)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VJOCz-0001lX-10
	for qemu-devel@nongnu.org; Tue, 10 Sep 2013 09:42:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VJOCq-0000Ge-Jr
	for qemu-devel@nongnu.org; Tue, 10 Sep 2013 09:42:20 -0400
Received: from mail-qe0-x22b.google.com ([2607:f8b0:400d:c02::22b]:34139)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VJOCq-0000Ga-Fm
	for qemu-devel@nongnu.org; Tue, 10 Sep 2013 09:42:12 -0400
Received: by mail-qe0-f43.google.com with SMTP id gh4so4279196qeb.16
	for <qemu-devel@nongnu.org>; Tue, 10 Sep 2013 06:42:12 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <522F21B8.80505@redhat.com>
Date: Tue, 10 Sep 2013 15:42:16 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1378818985-12584-1-git-send-email-famz@redhat.com>
	<1378818985-12584-6-git-send-email-famz@redhat.com>
In-Reply-To: <1378818985-12584-6-git-send-email-famz@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH v4 5/6] configure: introduce
	--enable-modules
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: peter.maydell@linaro.org, mjt@tls.msk.ru, qemu-devel@nongnu.org, stefanha@redhat.com, vilanova@ac.upc.edu, rth@twiddle.net

Il 10/09/2013 15:16, Fam Zheng ha scritto:
> +ifeq ($(CONFIG_MODULES),y)
>  define add-modules
>  $(foreach o,$(filter %.o,$($1)),$(eval \
>  	$(patsubst %.o,%.mo,$o): $o))
> @@ -146,6 +147,13 @@ dummy := $(call add-modules,common-obj-m)
>  
>  modules: $(patsubst %.mo,%$(DSOSUF),$(modules-m))
>  all: modules
> +else
> +block-obj-y += $(block-obj-m)
> +common-obj-y += $(common-obj-m)
> +block-obj-m :=
> +common-obj-m :=
> +endif
> +

Should this be done in unnest-vars instead?

Paolo