From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40992) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJQF7-0004ed-87 for qemu-devel@nongnu.org; Tue, 10 Sep 2013 11:52:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VJQF2-0001oU-W8 for qemu-devel@nongnu.org; Tue, 10 Sep 2013 11:52:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57467) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJQF2-0001oK-OS for qemu-devel@nongnu.org; Tue, 10 Sep 2013 11:52:36 -0400 Message-ID: <522F4038.3030401@redhat.com> Date: Tue, 10 Sep 2013 09:52:24 -0600 From: Eric Blake MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9f7UC5oC2dtvALnkJdiDI0oupQJJNp6io" Subject: Re: [Qemu-devel] [RFC qom-cpu v2 3/8] qmp: add 'cpu-del' command support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chen Fan Cc: Igor Mammedov , qemu-devel@nongnu.org, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9f7UC5oC2dtvALnkJdiDI0oupQJJNp6io Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/10/2013 03:43 AM, Chen Fan wrote: > Signed-off-by: Chen Fan > --- > hw/i386/pc.c | 5 +++++ > hw/i386/pc_piix.c | 1 + > include/hw/boards.h | 2 ++ > include/hw/i386/pc.h | 1 + > qapi-schema.json | 12 ++++++++++++ > qmp-commands.hx | 23 +++++++++++++++++++++++ > qmp.c | 9 +++++++++ > 7 files changed, 53 insertions(+) >=20 > diff --git a/hw/i386/pc.c b/hw/i386/pc.c > index 0c313fe..3de9c51 100644 > --- a/hw/i386/pc.c > +++ b/hw/i386/pc.c > @@ -957,6 +957,11 @@ void pc_hot_add_cpu(const int64_t id, Error **errp= ) > pc_new_cpu(current_cpu_model, apic_id, icc_bridge, errp); > } > =20 > +void pc_hot_del_cpu(const int64_t id, Error **errp) > +{ > + /* TODO: hot remove vCPU. */ Even if you implement things later, it's better to at least set errp here rather than having a command that silently does nothing but succeeds. Or squash the two patches together so that you are providing functionality at the time you expose the QMP. Otherwise, looks fine from the QMP perspective. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --9f7UC5oC2dtvALnkJdiDI0oupQJJNp6io Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSL0A4AAoJEKeha0olJ0NqJiIIAJJg0fxS7xiXVFNmIwpBzJ7h gKykHc6Go2UgMgDeKDstm/I6IsZygysBY7AEY+UT3RdbRyYc0L5GPdjs3hJfkdxr jRih2jjH2T+rKUUNvqUGCXxF3LEwT50wqXBs4Oy3gIWs0BfO+qq2Q4/PPGCnZbMH AZUHzn9S8P81njjbjpoqF6f/BnepHImi5epUNJKcMqPxMKwO0lyouziIxbCAEY7l oYXoQXFiCxPThL9/E/WK3ZrfdYSphpLTzHi2JHurc4pPiQyL0fl7PgCgzXu1SCS8 wwCMnNZLlnB4IwbcSu7+Nd7dm65KrDnbDFXsI1+/d2k3SaoLRxC2lZ1489Q/W7o= =ZQXq -----END PGP SIGNATURE----- --9f7UC5oC2dtvALnkJdiDI0oupQJJNp6io--