From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41218) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJQG3-0005eX-Rx for qemu-devel@nongnu.org; Tue, 10 Sep 2013 11:53:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VJQFx-00027M-Io for qemu-devel@nongnu.org; Tue, 10 Sep 2013 11:53:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6991) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJQFx-00027C-7V for qemu-devel@nongnu.org; Tue, 10 Sep 2013 11:53:33 -0400 Message-ID: <522F4076.5080302@redhat.com> Date: Tue, 10 Sep 2013 09:53:26 -0600 From: Eric Blake MIME-Version: 1.0 References: <1378819619-20579-1-git-send-email-ottlik@fzi.de> <1378819619-20579-4-git-send-email-ottlik@fzi.de> In-Reply-To: <1378819619-20579-4-git-send-email-ottlik@fzi.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qnvmR1g2dSdniOhjvetABjdvIwwWXHPLW" Subject: Re: [Qemu-devel] [PATCH v3 3/5] net: call socket_set_fast_reuse instead of setting SO_REUSEADDR List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sebastian Ottlik Cc: Jan Kiszka , Anthony Liguori , qemu-devel@nongnu.org, Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qnvmR1g2dSdniOhjvetABjdvIwwWXHPLW Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/10/2013 07:26 AM, Sebastian Ottlik wrote: > SO_REUSEADDR should be avoided on Windows but is desired on other opera= ting > systems. So instead of setting it we call socket_set_fast_reuse that wi= ll result > in the appropriate behaviour on all operating systems. >=20 > An exception to this rule are multicast sockets where it is sensible to= have > multiple sockets listen on the same ip and port an we should set SO_REU= SEADDR on s/an/and/ > windows. >=20 > Signed-off-by: Sebastian Ottlik > --- > net/socket.c | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --qnvmR1g2dSdniOhjvetABjdvIwwWXHPLW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSL0B2AAoJEKeha0olJ0Nq+1kIAK0Fkeenn9vDSDtluuB+57xT 0JOW8oicdkh8KDvaADG2C5GxnT3K8SJey4qUamDn4RyCdgCf41bWn/JlauTIdYiK UGQBsphdOo+5IAZVtMwXTEUubFc4Ko/aeJGoORkU+uBnSkZlrfvGisAzIJofv0Dj OzYTD4QwSPfBvxy5LXdi7a0+555MT8zdho9y9J6uPpEW3qt1QhCD2FsP7IOztK19 HZ3aLUoZa1MuMcVgfakUDJUWoEOXcHu2+8Ny0Y6Wha+QkaD1Yfn4vgJyHrc5BIww wlqKpHHiTpVP871YUDjh9Bk9IhuELug2RcSwyALkSllD1oiM26OJDROvAfXDy8o= =mjGY -----END PGP SIGNATURE----- --qnvmR1g2dSdniOhjvetABjdvIwwWXHPLW--