From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53888)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VJdiB-0008Aq-07
	for qemu-devel@nongnu.org; Wed, 11 Sep 2013 02:15:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VJdi2-0008Vd-6z
	for qemu-devel@nongnu.org; Wed, 11 Sep 2013 02:15:34 -0400
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <52300A72.9090009@redhat.com>
Date: Wed, 11 Sep 2013 08:15:14 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1377857738-14789-1-git-send-email-aik@ozlabs.ru>
	<1377857738-14789-4-git-send-email-aik@ozlabs.ru>
	<1378406985.3246.256.camel@ul30vt.home>
	<522ED6B3.6020302@ozlabs.ru>
	<1378850527.2631.314.camel@ul30vt.home>
In-Reply-To: <1378850527.2631.314.camel@ul30vt.home>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 03/12] vfio: Add guest side IOMMU support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>, David Gibson <david@gibson.dropbear.id.au>, qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org

Il 11/09/2013 00:02, Alex Williamson ha scritto:
>>> > > I would hope that when you do the below
>>> > > memory_region_register_iommu_notifier() the callback gets a replay of
>>> > > the current state of the iommu like we do for a memory region when we
>>> > > register the listener that gets us here.  Is that not the case?
>> > 
>> > 
>> > From what I see, it just adds a notifier:
>> > 
>> > void memory_region_register_iommu_notifier(MemoryRegion *mr, Notifier *n)
>> > {
>> >     notifier_list_add(&mr->iommu_notify, n);
>> > }
> Ok, that's too bad.  I guess your comment is justified then.
> 

That can be fixed by adding a new element ("replay") to the
MemoryRegionIOMMUOps.  It can be a follow-up.

Paolo