From: Paolo Bonzini <pbonzini@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: peter.maydell@linaro.org, Fam Zheng <famz@redhat.com>,
mjt@tls.msk.ru, qemu-devel@nongnu.org, stefanha@redhat.com,
vilanova@ac.upc.edu, rth@twiddle.net
Subject: Re: [Qemu-devel] [RFC PATCH v5 5/6] configure: introduce --enable-modules
Date: Wed, 11 Sep 2013 09:41:49 +0200 [thread overview]
Message-ID: <52301EBD.5070209@redhat.com> (raw)
In-Reply-To: <52301B4E.7000308@redhat.com>
Il 11/09/2013 09:27, Paolo Bonzini ha scritto:
>
> There are a couple of things that can be improved still (I don't like
> obj-save-y for example), but things are taking shape and all of this
> looks like something that can be fixed on top. If you look at
> converting more parts to modules (e.g. rbd or spice), you can drop that
> RFC! :)
Talking about spice, a question for Gerd.
With Fam's work to enable shared modules, hw/display/qxl* would have to
be placed in a module as well because they depend on ui/spice-core.c.
Right now, modularization is limited to files that are built once for
all of QEMU, which is not the case for qxl.
It looks like TARGET_PAGE_SIZE is the only reason why qxl is built
per-target, and in qxl_ram_set_dirty it should be enough to do
qxl_set_dirty(&qxl->vga.vram, offset, offset + 1);
Would it be fine to use a generic 4096 constant everywhere else?
Paolo
next prev parent reply other threads:[~2013-09-11 7:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 5:38 [Qemu-devel] [RFC PATCH v5 0/6] Shared Library Module Support Fam Zheng
2013-09-11 5:38 ` [Qemu-devel] [RFC PATCH v5 1/6] make.rule: fix $(obj) to a real relative path Fam Zheng
2013-09-11 6:30 ` Paolo Bonzini
2013-09-11 7:05 ` Fam Zheng
2013-09-11 5:38 ` [Qemu-devel] [RFC PATCH v5 2/6] rule.mak: allow per object cflags and libs Fam Zheng
2013-09-11 5:38 ` [Qemu-devel] [RFC PATCH v5 3/6] Makefile: introduce common-obj-m and block-obj-m for DSO Fam Zheng
2013-09-11 5:38 ` [Qemu-devel] [RFC PATCH v5 4/6] module: implement module loading function Fam Zheng
2013-09-11 7:36 ` Paolo Bonzini
2013-09-11 14:10 ` Alex Bligh
2013-09-11 14:32 ` Paolo Bonzini
2013-09-11 15:06 ` Richard Henderson
2013-09-11 15:23 ` Alex Bligh
2013-09-11 15:43 ` Richard Henderson
2013-09-11 14:24 ` Peter Maydell
2013-09-12 3:12 ` Fam Zheng
2013-09-11 5:38 ` [Qemu-devel] [RFC PATCH v5 5/6] configure: introduce --enable-modules Fam Zheng
2013-09-11 7:27 ` Paolo Bonzini
2013-09-11 7:41 ` Paolo Bonzini [this message]
2013-09-11 8:01 ` Gerd Hoffmann
2013-09-11 8:17 ` Fam Zheng
2013-09-11 8:20 ` Peter Maydell
2013-09-11 8:56 ` Gerd Hoffmann
2013-09-11 10:03 ` Peter Maydell
2013-09-11 10:37 ` Gerd Hoffmann
2013-09-11 10:58 ` Peter Maydell
2013-09-11 8:35 ` Fam Zheng
2013-09-11 8:47 ` Paolo Bonzini
2013-09-11 5:38 ` [Qemu-devel] [RFC PATCH v5 6/6] block: build qed and curl as shared library Fam Zheng
2013-09-11 7:28 ` Paolo Bonzini
2013-09-11 7:36 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52301EBD.5070209@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=kraxel@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).