From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45092) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJfE2-0007ui-Rb for qemu-devel@nongnu.org; Wed, 11 Sep 2013 03:52:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VJfDx-0003EU-Q1 for qemu-devel@nongnu.org; Wed, 11 Sep 2013 03:52:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8220) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJfDx-0003DI-Hx for qemu-devel@nongnu.org; Wed, 11 Sep 2013 03:52:29 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8B7qSIG004121 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 11 Sep 2013 03:52:28 -0400 Message-ID: <52302139.7030707@redhat.com> Date: Wed, 11 Sep 2013 09:52:25 +0200 From: Max Reitz MIME-Version: 1.0 References: <1378805602-24044-1-git-send-email-mreitz@redhat.com> <1378805602-24044-7-git-send-email-mreitz@redhat.com> <20130911062318.GA28768@T430s.nay.redhat.com> <52301B18.3030308@redhat.com> <20130911074456.GC2520@T430s.nay.redhat.com> In-Reply-To: <20130911074456.GC2520@T430s.nay.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 6/6] qemu-iotests: Additional info from qemu-img info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: famz@redhat.com Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi On 2013-09-11 09:44, Fam Zheng wrote: > On Wed, 09/11 09:26, Max Reitz wrote: >> On 2013-09-11 08:23, Fam Zheng wrote: >>> On Tue, 09/10 11:33, Max Reitz wrote: >>>> Add a test for the additional information now provided by qemu-img i= nfo >>>> when used on qcow2 images. >>>> >>>> Signed-off-by: Max Reitz >>>> --- >>>> tests/qemu-iotests/064 | 72 ++++++++++++++++++++++++++++++++++= ++++++++++++ >>>> tests/qemu-iotests/064.out | 22 ++++++++++++++ >>>> tests/qemu-iotests/group | 1 + >>>> 3 files changed, 95 insertions(+) >>>> create mode 100755 tests/qemu-iotests/064 >>>> create mode 100644 tests/qemu-iotests/064.out >>>> >>>> diff --git a/tests/qemu-iotests/064 b/tests/qemu-iotests/064 >>>> new file mode 100755 >>>> index 0000000..4979db5 >>>> --- /dev/null >>>> +++ b/tests/qemu-iotests/064 >>>> @@ -0,0 +1,72 @@ >>>> +#!/bin/bash >>>> +# >>>> +# Test for additional information emitted by qemu-img info on qcow2 >>>> +# images >>>> +# >>>> +# Copyright (C) 2013 Red Hat, Inc. >>>> +# >>>> +# This program is free software; you can redistribute it and/or mod= ify >>>> +# it under the terms of the GNU General Public License as published= by >>>> +# the Free Software Foundation; either version 2 of the License, or >>>> +# (at your option) any later version. >>>> +# >>>> +# This program is distributed in the hope that it will be useful, >>>> +# but WITHOUT ANY WARRANTY; without even the implied warranty of >>>> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>>> +# GNU General Public License for more details. >>>> +# >>>> +# You should have received a copy of the GNU General Public License >>>> +# along with this program. If not, see . >>>> +# >>>> + >>>> +# creator >>>> +owner=3Dmreitz@redhat.com >>>> + >>>> +seq=3D`basename $0` >>>> +echo "QA output created by $seq" >>>> + >>>> +here=3D`pwd` >>>> +tmp=3D/tmp/$$ >>>> +status=3D1 # failure is the default! >>>> + >>>> +_cleanup() >>>> +{ >>>> + _cleanup_test_img >>>> +} >>>> +trap "_cleanup; exit \$status" 0 1 2 3 15 >>>> + >>>> +# get standard environment, filters and checks >>>> +. ./common.rc >>>> +. ./common.filter >>>> + >>>> +# This tests qocw2-specific low-level functionality >>>> +_supported_fmt qcow2 >>>> +_supported_proto generic >>>> +_supported_os Linux >>>> + >>>> +IMG_SIZE=3D64M >>>> + >>>> +echo >>>> +echo "=3D=3D=3D Testing qcow2 image with -o compat=3D0.10 =3D=3D=3D= " >>>> +echo >>>> +IMGOPTS=3D"compat=3D0.10" _make_test_img $IMG_SIZE >>>> +# don't use _img_info, since that function will filter out the >>>> +# additional information we're about to test for >>>> +$QEMU_IMG info "$TEST_IMG" | grep "Format specific information:" -A= 42 >>> For curiosity, where's 42 from? >> I want to read all format specific information there, and because >> this is the last information emitted by qemu_img -info, I have to >> grep everything after the line "Format specific information:" until >> EOF =E2=80=93 I didn't find an easy way to do this, so I just chose a = number >> of lines which seemed enough to fetch all of that format specific >> info (currently, 2 would suffice). >> > Maybe > $QEMU_IMG info "$TEST_IMG" | sed -n 'Format specific information:/= ,$ p' > ? > > Fam Hm, yes, with a slash up front ('/Format specific information:/,$p') it=20 works, I'll use that, then. Thanks. Max