From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60723) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJg5E-0002XL-9x for qemu-devel@nongnu.org; Wed, 11 Sep 2013 04:47:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VJg56-0004K2-KD for qemu-devel@nongnu.org; Wed, 11 Sep 2013 04:47:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17246) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJg56-0004IW-CH for qemu-devel@nongnu.org; Wed, 11 Sep 2013 04:47:24 -0400 Message-ID: <52302E1D.8030604@redhat.com> Date: Wed, 11 Sep 2013 10:47:25 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1378877909-28518-1-git-send-email-famz@redhat.com> <1378877909-28518-6-git-send-email-famz@redhat.com> <52301B4E.7000308@redhat.com> <20130911083543.GB28040@T430s.nay.redhat.com> In-Reply-To: <20130911083543.GB28040@T430s.nay.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v5 5/6] configure: introduce --enable-modules List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: famz@redhat.com Cc: peter.maydell@linaro.org, mjt@tls.msk.ru, qemu-devel@nongnu.org, stefanha@redhat.com, vilanova@ac.upc.edu, rth@twiddle.net Il 11/09/2013 10:35, Fam Zheng ha scritto: >> > Since you'll have a v6, please move "all: modules" to Makefile, and in >> > rules.mak: >> > >> > .PHONY: modules >> > modules: >> > > Why is ".PHONY: modules" not in Makefile too? I think you would need it even in Makefile.target, so I suggested rules.mak. > And why do we need blank > "modules:", with the real one generated above? Just for clarity, since the target is declared only in a somewhat hidden manner through $(eval). Paolo