From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53750) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJkzP-0007dE-BF for qemu-devel@nongnu.org; Wed, 11 Sep 2013 10:01:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VJkzJ-0002C8-Qz for qemu-devel@nongnu.org; Wed, 11 Sep 2013 10:01:51 -0400 Sender: Paolo Bonzini Message-ID: <523077CE.6070303@redhat.com> Date: Wed, 11 Sep 2013 16:01:50 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1378906912-14015-1-git-send-email-gabriel@kerneis.info> In-Reply-To: <1378906912-14015-1-git-send-email-gabriel@kerneis.info> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Quote extra_cflags in config-host.mak List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gabriel Kerneis Cc: qemu-trivial@nongnu.org, Peter Maydell , qemu-devel@nongnu.org Il 11/09/2013 15:41, Gabriel Kerneis ha scritto: > The variable extra_cflags needs to be quoted in config-host.mak, > in particular because it might contain parentheses that would > otherwise be interpreted by the shell when reloading the file. > > For instance, if one wants to define some attribute with configure: > > ./configure --extra-cflags="-Dcoroutine_fn='__attribute__((coroutine_fn))'" > > A more robust approach would be to escape every variable properly, but > there is no portable equivalent to bash's "printf %q" solution. The > current patch, while not bullet-proof, works well in the common case. > > Signed-off-by: Gabriel Kerneis Where does the shell read config-host.mak? Make does not need the quotes. Paolo