From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50918) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJmMO-0004uK-8M for qemu-devel@nongnu.org; Wed, 11 Sep 2013 11:29:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VJmMI-000696-9g for qemu-devel@nongnu.org; Wed, 11 Sep 2013 11:29:40 -0400 Message-ID: <52308C52.5090001@redhat.com> Date: Wed, 11 Sep 2013 17:29:22 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1378906912-14015-1-git-send-email-gabriel@kerneis.info> <523077CE.6070303@redhat.com> <20130911144230.GA15227@kerneis.info> <523083EF.7050203@redhat.com> <20130911150137.GC15227@kerneis.info> <52308701.1020706@redhat.com> <20130911151628.GB22569@kerneis.info> <20130911152327.GC22569@kerneis.info> In-Reply-To: <20130911152327.GC22569@kerneis.info> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Quote extra_cflags in config-host.mak List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gabriel Kerneis Cc: qemu-trivial@nongnu.org, Peter Maydell , qemu-devel@nongnu.org Il 11/09/2013 17:23, Gabriel Kerneis ha scritto: > On Wed, Sep 11, 2013 at 04:16:28PM +0100, Gabriel Kerneis wrote: >>> > > Yeah, what I'm missing now is why your patch works. >> > >> > That is indeed very mysterious :-) > Okay, the answer is simple enough: it doesn't fix the issue at all. > Long story short, I had a sed script to rewrite the faulty extra_cflags= > line but I did not realize it *also* fixed the "Configured with:" line! > Then turned that into a patch for QEMU, and didn't test it thoroughly > enough, with the aforementioned chicken-and-egg issue. > > Oh well, please ignore this whole thread. I'll fix it properly tomorrow. No problem at all, it happens. Shell is boring, let's go shopping. Paolo