From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44953) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJnk7-00081o-58 for qemu-devel@nongnu.org; Wed, 11 Sep 2013 12:58:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VJnk2-0000g8-5k for qemu-devel@nongnu.org; Wed, 11 Sep 2013 12:58:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9490) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJnk1-0000fw-S3 for qemu-devel@nongnu.org; Wed, 11 Sep 2013 12:58:10 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8BGw8Mv015491 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 11 Sep 2013 12:58:08 -0400 Message-ID: <5230A11F.7010603@redhat.com> Date: Wed, 11 Sep 2013 10:58:07 -0600 From: Eric Blake MIME-Version: 1.0 References: <1378918072-1963-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1378918072-1963-1-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="U5O5VPutcHF5ql018JQ0Giha576bCosHl" Subject: Re: [Qemu-devel] [PATCH] qemu-img: fix invalid JSON List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --U5O5VPutcHF5ql018JQ0Giha576bCosHl Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/11/2013 10:47 AM, Paolo Bonzini wrote: > Single quotes for JSON are a QMP-ism, use real JSON in > qemu-img output. >=20 > Reported-by: Kevin Wolf > Signed-off-by: Paolo Bonzini > --- > qemu-img.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake >=20 > diff --git a/qemu-img.c b/qemu-img.c > index 3e5e388..626365d 100644 > --- a/qemu-img.c > +++ b/qemu-img.c > @@ -1842,7 +1842,7 @@ static void dump_map_entry(OutputFormat output_fo= rmat, MapEntry *e, > (e->flags & BDRV_BLOCK_ZERO) ? "true" : "false", > (e->flags & BDRV_BLOCK_DATA) ? "true" : "false"); > if (e->flags & BDRV_BLOCK_OFFSET_VALID) { > - printf(", 'offset': %"PRId64"", e->offset); > + printf(", \"offset\": %"PRId64"", e->offset); > } > putchar('}'); > =20 >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --U5O5VPutcHF5ql018JQ0Giha576bCosHl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSMKEgAAoJEKeha0olJ0Nqc90H/22CJ8PE3OdRUgLqphLlDTjy AlW3GmOvAq2E9vQUhyeXJJm33T5ei6Hp16/N4V8AQjNJ6jGTCFKK94vAZDgWBOsB N4IwxkkiklAWJrsIlf4OaJDZuvSk7DBzfQrfk+5WchrTGr85Ba1+XV/SSllK7RCx 1GMuQ9Xm78cqlegRhvdIsiilptOhnDtpxkj6BYBJRInDSGhwTZkM1L3Xk7bS6eRX WEwqsoTZuKiJEX+nMPLtUngX/yVsJahWmOYAfpWrq+Apm+R3UnSLICTCnwnIU7yP 8lETg3MfUkmrNQ9+6PrOCsdJ0mKz8mJBZx4uGCn6VNDstVABhdNls/5vpLD8ZbU= =vDBw -----END PGP SIGNATURE----- --U5O5VPutcHF5ql018JQ0Giha576bCosHl--