From: Richard Henderson <rth@twiddle.net>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: peter.maydell@linaro.org, Fam Zheng <famz@redhat.com>,
mjt@tls.msk.ru, qemu-devel@nongnu.org, stefanha@redhat.com,
pbonzini@redhat.com, vilanova@ac.upc.edu
Subject: Re: [Qemu-devel] [PATCH v6 4/8] module: implement module loading function
Date: Wed, 11 Sep 2013 11:46:01 -0700 [thread overview]
Message-ID: <5230BA69.1000202@twiddle.net> (raw)
In-Reply-To: <20130911154841.GD2293@redhat.com>
On 09/11/2013 08:48 AM, Daniel P. Berrange wrote:
> We know the precise list of valid modules when building QEMU,
> so IMHO, this should just explicitly load each known module
> name, and *not* readdir. Also it should do something along the
> lines suggested their of poisoning exported symbols with a
> build hash to guarantee the modules loaded match the original
> binary and that the symbols change on every rebuild.
We need not mangle the symbols, which could be complicated to
actually implement, and irritating to work around within gdb.
We could instead just add the build-id as a variable within
the module. Read and compare the build-id after loading the
module; unload and reject on mismatch.
r~
next prev parent reply other threads:[~2013-09-11 18:46 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 13:34 [Qemu-devel] [PATCH v6 0/8] Shared Library Module Support Fam Zheng
2013-09-11 13:34 ` [Qemu-devel] [PATCH v6 1/8] make.rule: fix $(obj) to a real relative path Fam Zheng
2013-09-11 13:41 ` Paolo Bonzini
2013-09-12 2:32 ` Fam Zheng
2013-09-11 14:59 ` Daniel P. Berrange
2013-09-12 1:57 ` Fam Zheng
2013-09-12 2:22 ` Fam Zheng
2013-09-11 16:38 ` Peter Maydell
2013-09-11 16:40 ` Paolo Bonzini
2013-09-11 16:43 ` Peter Maydell
2013-09-11 13:34 ` [Qemu-devel] [PATCH v6 2/8] rule.mak: allow per object cflags and libs Fam Zheng
2013-09-11 13:43 ` Paolo Bonzini
2013-09-12 2:52 ` Fam Zheng
2013-09-12 6:34 ` Paolo Bonzini
2013-09-12 7:12 ` Fam Zheng
2013-09-11 13:34 ` [Qemu-devel] [PATCH v6 3/8] Makefile: introduce common-obj-m and block-obj-m for DSO Fam Zheng
2013-09-11 20:01 ` Peter Maydell
2013-09-12 2:48 ` Fam Zheng
2013-09-12 2:50 ` Fam Zheng
2013-09-11 13:34 ` [Qemu-devel] [PATCH v6 4/8] module: implement module loading function Fam Zheng
2013-09-11 15:48 ` Daniel P. Berrange
2013-09-11 18:33 ` Alex Bligh
2013-09-11 18:46 ` Richard Henderson [this message]
2013-09-12 3:02 ` Fam Zheng
2013-09-12 5:36 ` Michael Tokarev
2013-09-12 9:13 ` Daniel P. Berrange
2013-09-12 11:59 ` Eric Blake
2013-09-12 12:44 ` Daniel P. Berrange
2013-09-11 13:34 ` [Qemu-devel] [PATCH v6 5/8] configure: introduce --enable-modules Fam Zheng
2013-09-11 13:46 ` Paolo Bonzini
2013-09-12 2:06 ` Fam Zheng
2013-09-11 13:34 ` [Qemu-devel] [PATCH v6 6/8] Makefile: install modules with "make install" Fam Zheng
2013-09-11 13:50 ` Paolo Bonzini
2013-09-12 2:00 ` Fam Zheng
2013-09-11 13:34 ` [Qemu-devel] [PATCH v6 7/8] .gitignore: ignore module related files (dll, so, mo) Fam Zheng
2013-09-11 13:34 ` [Qemu-devel] [PATCH v6 8/8] block: convert block drivers linked with libs to modules Fam Zheng
2013-09-11 15:41 ` Daniel P. Berrange
2013-09-12 2:07 ` Fam Zheng
2013-09-11 16:26 ` [Qemu-devel] [PATCH v6 0/8] Shared Library Module Support Peter Maydell
2013-09-12 3:08 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5230BA69.1000202@twiddle.net \
--to=rth@twiddle.net \
--cc=berrange@redhat.com \
--cc=famz@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).