From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51021) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJsfU-0001ki-F0 for qemu-devel@nongnu.org; Wed, 11 Sep 2013 18:13:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VJsfG-0006Qy-5J for qemu-devel@nongnu.org; Wed, 11 Sep 2013 18:13:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28341) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJsfF-0006Pl-RA for qemu-devel@nongnu.org; Wed, 11 Sep 2013 18:13:34 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8BMDXew017602 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 11 Sep 2013 18:13:33 -0400 Message-ID: <5230EB0C.7050507@redhat.com> Date: Wed, 11 Sep 2013 16:13:32 -0600 From: Eric Blake MIME-Version: 1.0 References: <1378932737-13422-1-git-send-email-lcapitulino@redhat.com> <1378932737-13422-2-git-send-email-lcapitulino@redhat.com> <5230E9FB.5080101@redhat.com> In-Reply-To: <5230E9FB.5080101@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sRQ58WjE7pvtsnnogWVfUNm5e5vHqSFXM" Subject: Re: [Qemu-devel] [PATCH 1/6] QMP: add scripts/qmp List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: armbru@redhat.com, qemu-devel@nongnu.org, Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --sRQ58WjE7pvtsnnogWVfUNm5e5vHqSFXM Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/11/2013 04:08 PM, Eric Blake wrote: > On 09/11/2013 02:52 PM, Luiz Capitulino wrote: >> Populate it with all scripts stored in QMP/. >> >> Signed-off-by: Luiz Capitulino > Reviewed-by: Eric Blake >=20 > Repeat after me: > git config diff.renames true >=20 > at which point, this commit is much more compact and reviewable: >=20 Oh, and while testing your patch: :1854: trailing whitespace. :2054: trailing whitespace. # warning: 2 lines add whitespace errors. One instance from qmp-shell; the other from qmp.py. It's okay if you touch those up as part of this rename (again, the diff.renames true bit will highlight those two changes, rather than showing the complete file as a delete and addition). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --sRQ58WjE7pvtsnnogWVfUNm5e5vHqSFXM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSMOsMAAoJEKeha0olJ0Nq514H/jLxsPCwaNOY+15m81J38ywC 3hJnJ7LgFLq7X2+Hy9JskS1lwI7YG6zB9N2puxkWLvlMrX5pWCWNkYnnk7u9vHHW qBI7Uz6b6Z0RsxBTejRHahH85RNDeb1dfwWJSMDQ7oW7z8yk7hs41STmvvyZC2/E B3p1lYksRO5QHn+OAoMv3DRjc2w1kUC4vck4R6nhZ4RvTXz6x5C9tsCgnxbz5/Hz xU7aNtilm9j80hJC21KBo4/MLufWejhJLFx6NdyVm+Kc2ftwr5+KeiNtaFO7sPu2 i+8c6HUpZDgFPkRzbW2DVc/C7tk/OCqH8+n1oY7Newpsg2SnofL1f0iTgYc3KyI= =x0k6 -----END PGP SIGNATURE----- --sRQ58WjE7pvtsnnogWVfUNm5e5vHqSFXM--