qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] hw/i386: Deprecate the machine types pc-0.10 and pc-0.11
Date: Wed, 20 Jun 2018 20:40:38 +0200	[thread overview]
Message-ID: <5231573e-f53d-dba2-e39c-5f3755505cca@redhat.com> (raw)
In-Reply-To: <20180611221859.GE7451@localhost.localdomain>

On 12.06.2018 00:18, Eduardo Habkost wrote:
> On Mon, Jun 11, 2018 at 05:41:04AM +0200, Thomas Huth wrote:
>> The oldest machine type which is still used in a maintained distribution
>> is a pc-0.12 based machine type in RHEL6, so everything that is older
>> than pc-0.12 should not be used anymore. Thus let's deprecate pc-0.10
>> and pc-0.11 so that we can finally remove them in a future release.
[...]
>> @@ -3952,6 +3953,10 @@ int main(int argc, char **argv, char **envp)
>>      }
>>  
>>      machine_class = select_machine();
>> +    if (machine_class->deprecation_msg) {
>> +        error_report("Machine type '%s' is deprecated: %s",
>> +                     machine_class->name, machine_class->deprecation_msg);
>> +    }
> 
> Do you plan to add this info to 'query-machines' QMP command?

No, I'm not planning to add this. We'd need a request from upper layers
(i.e. libvirt) for this first, otherwise it's just a dead interface that
nobody is using.

 Thomas

  reply	other threads:[~2018-06-20 18:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-11  3:41 [Qemu-devel] [PATCH] hw/i386: Deprecate the machine types pc-0.10 and pc-0.11 Thomas Huth
2018-06-11 22:18 ` Eduardo Habkost
2018-06-20 18:40   ` Thomas Huth [this message]
2018-06-20 22:43     ` Eduardo Habkost
2018-06-21  5:56   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5231573e-f53d-dba2-e39c-5f3755505cca@redhat.com \
    --to=thuth@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).