From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36491) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VK2cv-0006pc-SM for qemu-devel@nongnu.org; Thu, 12 Sep 2013 04:51:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VK2cp-0004uV-9M for qemu-devel@nongnu.org; Thu, 12 Sep 2013 04:51:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:8881) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VK2cp-0004uQ-0R for qemu-devel@nongnu.org; Thu, 12 Sep 2013 04:51:43 -0400 Message-ID: <523180A4.4080700@redhat.com> Date: Thu, 12 Sep 2013 10:51:48 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1378831204-25256-1-git-send-email-pbonzini@redhat.com> <20130912083808.GF1965@stefanha-thinkpad.redhat.com> In-Reply-To: <20130912083808.GF1965@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] scsi: prefer UUID to VM name for the initiator name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org Il 12/09/2013 10:38, Stefan Hajnoczi ha scritto: > On Tue, Sep 10, 2013 at 06:40:04PM +0200, Paolo Bonzini wrote: >> The UUID is unique even across multiple hosts, thus it is >> better than a VM name even if it is less user-friendly. >> >> Signed-off-by: Paolo Bonzini >> --- >> block/iscsi.c | 23 ++++++++++++++++------- >> include/sysemu/sysemu.h | 2 ++ >> stubs/Makefile.objs | 1 + >> stubs/uuid.c | 12 ++++++++++++ >> 4 files changed, 31 insertions(+), 7 deletions(-) >> create mode 100644 stubs/uuid.c > > Will changing the initiator name break existing setups/ACLs? The username for authentication is separate from the initiator name. It could break persistent reservations, but there is a workaround (specify the initiator name manually through "-iscsi"). I'll make sure to document this in the release changelog. Does it look good? Paolo