From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46699)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VK6qL-0006kE-Ib
	for qemu-devel@nongnu.org; Thu, 12 Sep 2013 09:22:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VK6qG-0001bK-6o
	for qemu-devel@nongnu.org; Thu, 12 Sep 2013 09:21:57 -0400
Received: from mail-pa0-x236.google.com ([2607:f8b0:400e:c03::236]:46094)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VK6qF-0001b9-Va
	for qemu-devel@nongnu.org; Thu, 12 Sep 2013 09:21:52 -0400
Received: by mail-pa0-f54.google.com with SMTP id kx10so1096798pab.27
	for <qemu-devel@nongnu.org>; Thu, 12 Sep 2013 06:21:50 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <5231BFEA.5010409@twiddle.net>
Date: Thu, 12 Sep 2013 06:21:46 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1378144503-15808-1-git-send-email-rth@twiddle.net>
	<1378144503-15808-2-git-send-email-rth@twiddle.net>
	<52317A6C.20400@huawei.com>
	<CAFEAcA8wn5xE8rdizvGjhJ6musCFCPS0DDYEKtc8GcdYPgCDAA@mail.gmail.com>
In-Reply-To: <CAFEAcA8wn5xE8rdizvGjhJ6musCFCPS0DDYEKtc8GcdYPgCDAA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 01/29] tcg-aarch64: Set ext based on
	TCG_OPF_64BIT
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Claudio Fontana <claudio.fontana@huawei.com>, QEMU Developers <qemu-devel@nongnu.org>

On 09/12/2013 01:58 AM, Peter Maydell wrote:
> On 12 September 2013 09:25, Claudio Fontana <claudio.fontana@huawei.com> wrote:
>> On 02.09.2013 19:54, Richard Henderson wrote:
>>>
>>> -    case INDEX_op_bswap64_i64:
>>> -        ext = 1; /* fall through */
>>>      case INDEX_op_bswap32_i64:
>>> +        /* Despite the _i64, this is a 32-bit bswap.  */
>>> +        ext = 0;
>>> +        /* FALLTHRU */
>>> +    case INDEX_op_bswap64_i64:
>>
>> we waste too much y space here, which gives context and is a scarse resource.
>> What about
>>
>> case INDEX_op_bswap32_i64: /* Despite the _i64, this is a 32-bit bswap.  */
>>     ext = false; /* FALLTHRU */
> 
> Consensus in the rest of the code is for /* fall through */
> rather than /* FALLTHRU */ -- there's only 28 of the
> latter compared to 169 of the former.

Those 28 may well be all mine too.  The fingers still remember
that one must use FALLTHRU for lint.   ;-)


r~