From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51579) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VK7DJ-0004UK-FU for qemu-devel@nongnu.org; Thu, 12 Sep 2013 09:45:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VK7DA-0000HY-79 for qemu-devel@nongnu.org; Thu, 12 Sep 2013 09:45:41 -0400 Received: from mail-pb0-x236.google.com ([2607:f8b0:400e:c01::236]:33316) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VK7D9-0000HK-Q3 for qemu-devel@nongnu.org; Thu, 12 Sep 2013 09:45:32 -0400 Received: by mail-pb0-f54.google.com with SMTP id ro12so10656060pbb.27 for ; Thu, 12 Sep 2013 06:45:30 -0700 (PDT) Sender: Richard Henderson Message-ID: <5231C576.8030506@twiddle.net> Date: Thu, 12 Sep 2013 06:45:26 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1378144503-15808-1-git-send-email-rth@twiddle.net> <1378144503-15808-3-git-send-email-rth@twiddle.net> <52317B85.6070804@huawei.com> In-Reply-To: <52317B85.6070804@huawei.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 02/29] tcg-aarch64: Change all ext variables to bool List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Claudio Fontana Cc: qemu-devel@nongnu.org On 09/12/2013 01:29 AM, Claudio Fontana wrote: > I see the problem related to the previous patch. > What about continuing to use int in the previous patch, > and replace it with bool in this one? The previous patch would only target the way ext is set, > and this one would really contain all bool changes. For the next edition, I'm planning to swap the order of the first two patches, and also quit using bool. I think TCGType is a bit more descriptive here, and also uses the same 0/1 values that we want. I added a QEMU_BUILD_BUG_ON to assert that the enum values don't change. r~