From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55250)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VK7UG-000135-8L
	for qemu-devel@nongnu.org; Thu, 12 Sep 2013 10:03:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VK7U7-0005WW-Sh
	for qemu-devel@nongnu.org; Thu, 12 Sep 2013 10:03:12 -0400
Received: from mail-pb0-x236.google.com ([2607:f8b0:400e:c01::236]:48954)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VK7U7-0005WH-Le
	for qemu-devel@nongnu.org; Thu, 12 Sep 2013 10:03:03 -0400
Received: by mail-pb0-f54.google.com with SMTP id ro12so10591216pbb.13
	for <qemu-devel@nongnu.org>; Thu, 12 Sep 2013 07:03:00 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <5231C991.5080009@twiddle.net>
Date: Thu, 12 Sep 2013 07:02:57 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1378144503-15808-1-git-send-email-rth@twiddle.net>
	<1378144503-15808-4-git-send-email-rth@twiddle.net>
	<52317BBB.9040009@huawei.com>
In-Reply-To: <52317BBB.9040009@huawei.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 03/29] tcg-aarch64: Don't handle
	mov/movi in tcg_out_op
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Claudio Fontana <claudio.fontana@huawei.com>
Cc: qemu-devel@nongnu.org

On 09/12/2013 01:30 AM, Claudio Fontana wrote:
>> +    case INDEX_op_mov_i64:
>> +    case INDEX_op_mov_i32:
>> +    case INDEX_op_movi_i64:
>> +    case INDEX_op_movi_i32:
>> +        /* Always implemented with tcg_out_mov/i, never with tcg_out_op.  */
>>      default:
>> -        tcg_abort(); /* opcode not implemented */
>> +        /* Opcode not implemented.  */
>> +        tcg_abort();
>>      }
>>  }
>>  
> 
> Ok

Sadly, "Ok" is neither Reviewed-by or Signed-off-by.


r~