From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32971)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Claudio.Fontana@huawei.com>) id 1VK7vv-0007jC-TE
	for qemu-devel@nongnu.org; Thu, 12 Sep 2013 10:31:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Claudio.Fontana@huawei.com>) id 1VK7vo-0005BP-FZ
	for qemu-devel@nongnu.org; Thu, 12 Sep 2013 10:31:47 -0400
Received: from lhrrgout.huawei.com ([194.213.3.17]:22197)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Claudio.Fontana@huawei.com>) id 1VK7vo-0005AL-6n
	for qemu-devel@nongnu.org; Thu, 12 Sep 2013 10:31:40 -0400
Message-ID: <5231D024.6070508@huawei.com>
Date: Thu, 12 Sep 2013 16:31:00 +0200
From: Claudio Fontana <claudio.fontana@huawei.com>
MIME-Version: 1.0
References: <1378144503-15808-1-git-send-email-rth@twiddle.net>
	<1378144503-15808-4-git-send-email-rth@twiddle.net>
	<52317BBB.9040009@huawei.com> <5231C991.5080009@twiddle.net>
In-Reply-To: <5231C991.5080009@twiddle.net>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 03/29] tcg-aarch64: Don't handle
	mov/movi in tcg_out_op
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org

On 12.09.2013 16:02, Richard Henderson wrote:
> On 09/12/2013 01:30 AM, Claudio Fontana wrote:
>>> +    case INDEX_op_mov_i64:
>>> +    case INDEX_op_mov_i32:
>>> +    case INDEX_op_movi_i64:
>>> +    case INDEX_op_movi_i32:
>>> +        /* Always implemented with tcg_out_mov/i, never with tcg_out_op.  */
>>>      default:
>>> -        tcg_abort(); /* opcode not implemented */
>>> +        /* Opcode not implemented.  */
>>> +        tcg_abort();
>>>      }
>>>  }
>>>  
>>
>> Ok
> 
> Sadly, "Ok" is neither Reviewed-by or Signed-off-by.
> 
> 

There is nothing sad about it. When it's reviewed, you will know.