From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59274) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VK9o9-0004ID-8P for qemu-devel@nongnu.org; Thu, 12 Sep 2013 12:31:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VK9o4-00075X-Jl for qemu-devel@nongnu.org; Thu, 12 Sep 2013 12:31:53 -0400 Received: from mail-qc0-x22c.google.com ([2607:f8b0:400d:c01::22c]:63290) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VK9o4-00075T-FJ for qemu-devel@nongnu.org; Thu, 12 Sep 2013 12:31:48 -0400 Received: by mail-qc0-f172.google.com with SMTP id l13so27910qcy.17 for ; Thu, 12 Sep 2013 09:31:48 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5231EC7B.1050207@redhat.com> Date: Thu, 12 Sep 2013 18:31:55 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1378290385-7003-1-git-send-email-aik@ozlabs.ru> <20130909120750.GA20923@stefanha-thinkpad.redhat.com> In-Reply-To: <20130909120750.GA20923@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v2] kvm: fix traces to use %x instead of %d List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Alexey Kardashevskiy , qemu-devel@nongnu.org, Stefan Hajnoczi Il 09/09/2013 14:07, Stefan Hajnoczi ha scritto: > On Wed, Sep 04, 2013 at 08:26:25PM +1000, Alexey Kardashevskiy wrote: >> KVM request types are normally defined using hex constants but QEMU traces >> print decimal values instead, which is not very convenient. >> >> This changes the request type format from %d to %x. >> >> Signed-off-by: Alexey Kardashevskiy >> Reviewed-by: Andreas Färber >> Reviewed-by: Paolo Bonzini >> --- >> Changes: >> v2: >> * added "0x" to format strings so the change won't come unnoticed >> * fixed the commit message >> --- >> trace-events | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) > > Thanks, applied to my tracing tree: > https://github.com/stefanha/qemu/commits/tracing Applied also to uq/master, since I don't see it in github. Paolo