From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49720)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VKQCl-0005Re-Ag
	for qemu-devel@nongnu.org; Fri, 13 Sep 2013 06:02:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VKQCf-00053E-7K
	for qemu-devel@nongnu.org; Fri, 13 Sep 2013 06:02:23 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56728)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VKQCd-000520-A7
	for qemu-devel@nongnu.org; Fri, 13 Sep 2013 06:02:17 -0400
Message-ID: <5232E2AA.2000700@redhat.com>
Date: Fri, 13 Sep 2013 12:02:18 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1379061534-19171-1-git-send-email-famz@redhat.com>
	<1379061534-19171-6-git-send-email-famz@redhat.com>
	<1C973DFB-D08C-495D-A797-F93CC6BE2BE4@alex.org.uk>
In-Reply-To: <1C973DFB-D08C-495D-A797-F93CC6BE2BE4@alex.org.uk>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v8 5/9] module: implement module loading
 function
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Bligh <alex@alex.org.uk>
Cc: peter.maydell@linaro.org, Fam Zheng <famz@redhat.com>, mjt@tls.msk.ru, qemu-devel@nongnu.org, vilanova@ac.upc.edu, rth@twiddle.net

Il 13/09/2013 11:56, Alex Bligh ha scritto:
> 
> On 13 Sep 2013, at 09:38, Fam Zheng wrote:
> 
>> Added three types of modules:
>>
>>    typedef enum {
>>        MODULE_LOAD_BLOCK = 0,
>>        MODULE_LOAD_UI,
>>        MODULE_LOAD_NET,
>>        MODULE_LOAD_MAX,
>>    } module_load_type;
>>
>> and their loading function:
> 
> What is the advantage of this enum and having
> different types of module at all? If they are
> all built together, why can't they all live
> together in the same directory?
> 
> Seems like an overcomplication.

At least block have to be separate, since qemu-img and friends do not
have the symbols needed by ui, network and hardware modules.

Paolo