From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55663) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKQi4-000058-2E for qemu-devel@nongnu.org; Fri, 13 Sep 2013 06:34:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VKQhy-0005k2-1e for qemu-devel@nongnu.org; Fri, 13 Sep 2013 06:34:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40914) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKQhx-0005jx-Qg for qemu-devel@nongnu.org; Fri, 13 Sep 2013 06:34:37 -0400 Message-ID: <5232EA41.3030607@redhat.com> Date: Fri, 13 Sep 2013 12:34:41 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1379067909-22984-1-git-send-email-pl@kamp.de> <1379067909-22984-6-git-send-email-pl@kamp.de> In-Reply-To: <1379067909-22984-6-git-send-email-pl@kamp.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 05/12] block: add logical block provisioning information to BlockDriverInfo List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: kwolf@redhat.com, ronniesahlberg@gmail.com, stefanha@redhat.com, qemu-devel@nongnu.org, anthony@codemonkey.ws Il 13/09/2013 12:25, Peter Lieven ha scritto: > + /* maximum number of sectors that can be discarded at once */ > + int max_discard; > + /* maximum number of sectors that can zeroized at once */ > + int max_write_zeroes; These should not be needed outside the driver. If you want to make them private between block.c and block/iscsi.c, you can add them to BlockDriverState. Paolo