From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58432) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKQrv-0005Xf-Gu for qemu-devel@nongnu.org; Fri, 13 Sep 2013 06:45:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VKQrn-0000NK-3y for qemu-devel@nongnu.org; Fri, 13 Sep 2013 06:44:55 -0400 Received: from mx.ipv6.kamp.de ([2a02:248:0:51::16]:33057 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKQrm-0000NC-P6 for qemu-devel@nongnu.org; Fri, 13 Sep 2013 06:44:47 -0400 Message-ID: <5232EC9C.2060301@kamp.de> Date: Fri, 13 Sep 2013 12:44:44 +0200 From: Peter Lieven MIME-Version: 1.0 References: <1379067909-22984-1-git-send-email-pl@kamp.de> <1379067909-22984-6-git-send-email-pl@kamp.de> <5232EA41.3030607@redhat.com> In-Reply-To: <5232EA41.3030607@redhat.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 05/12] block: add logical block provisioning information to BlockDriverInfo List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, ronniesahlberg@gmail.com, stefanha@redhat.com, qemu-devel@nongnu.org, anthony@codemonkey.ws On 13.09.2013 12:34, Paolo Bonzini wrote: > Il 13/09/2013 12:25, Peter Lieven ha scritto: >> + /* maximum number of sectors that can be discarded at once */ >> + int max_discard; >> + /* maximum number of sectors that can zeroized at once */ >> + int max_write_zeroes; > These should not be needed outside the driver. > > If you want to make them private between block.c and block/iscsi.c, you > can add them to BlockDriverState. The question is, if the discard_zeroes or discard_write_zeroes is needed outside the driver as well? I can put the max_* information in the block driver state. I also thought to add alignment and granularity information even if they are currently not yet used. Peter