From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52158) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKUSC-0006Z0-1N for qemu-devel@nongnu.org; Fri, 13 Sep 2013 10:34:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VKUS7-00011M-55 for qemu-devel@nongnu.org; Fri, 13 Sep 2013 10:34:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34841) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKUS6-00011H-Su for qemu-devel@nongnu.org; Fri, 13 Sep 2013 10:34:31 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r8DEYUq0006491 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 13 Sep 2013 10:34:30 -0400 Message-ID: <52332274.8030200@redhat.com> Date: Fri, 13 Sep 2013 08:34:28 -0600 From: Eric Blake MIME-Version: 1.0 References: <1378106712-29856-1-git-send-email-mreitz@redhat.com> <5231D673.6050907@redhat.com> <5231DCA6.7090004@redhat.com> <20130913095753.GC2804@dhcp-200-207.str.redhat.com> <5232E78A.2030406@redhat.com> <52330516.10503@redhat.com> <52332150.8020804@redhat.com> In-Reply-To: <52332150.8020804@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FuLpRd9tHGdLVrEaRfnI1LPhk0emA4Iia" Subject: Re: [Qemu-devel] [PATCH v5 0/8] Add metadata overlap checks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --FuLpRd9tHGdLVrEaRfnI1LPhk0emA4Iia Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/13/2013 08:29 AM, Max Reitz wrote: > Another idea: Instead of providing an integer for "shorthand" > manipulations, what do you think of a string parameter (such as -o > cache=3Dfoo right now, although I do know -o cache isn't even document > anymore and provided only for compatibility reasons, it seems to me) > which will automatically be translated to the right settings? I'm > thinking of: > - overlap-check=3Dnone (no checks at all) > - overlap-check=3Dconstant (only checks who can be performed in consta= nt > time, i.e., main header, active L1, refcount table and snapshot table) > - overlap-check=3Dcached (only checks which don't require disk access,= > i.e. the current (and as I'd propose, future) default) > - overlap-check=3Dall (all checks, including those requiring disk acce= ss > (i.e., overlaps on inactive L2 tables)) Definitely a nice idea - saves the user from having to figure out which checks have which impact, by categorizing the types of checks and only exposing the categories. >=20 > These would then provide templates which can be further refined through= > the booleans (as is the case with -o cache right now). Probably don't need that much fine-tuning; your categories look pretty nice (although we may think of more categories if we do add additional checks with different levels of execution time). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --FuLpRd9tHGdLVrEaRfnI1LPhk0emA4Iia Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSMyJ0AAoJEKeha0olJ0NqI78IAJ2aLWuudNdH2bo7ih6GTxxs PXTb+XEoYAsfBDDGRDhSRiRxbS6JDDiGuilXZy88NF7Kndy/ACRocS7uNFVLIQ9b QJfI9vaW/vE57MgNYuIqaNLLxYsiIi4WEsXV8+EW9fyRliDlS+BTgoxzKumMvOHw T4cvG+WKABnhdIAOazR3U7EHN09SscDPDMUq8A4nH1JH6K50A1GpsYfqLHO3Eats Uh21lypwl968IE+BUVIrkKvHATcuiEXECOIQKb4eCIJ+hH/jo87xrQ6wyDGZbwA8 9atYtGJAM1FXn2LKHIMlCVQxsOiVz5P6v51kY/NlvDv5hkLg+HWFitrM46wA8Hs= =gl4i -----END PGP SIGNATURE----- --FuLpRd9tHGdLVrEaRfnI1LPhk0emA4Iia--