From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41565) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKXy2-0003Pz-IH for qemu-devel@nongnu.org; Fri, 13 Sep 2013 14:19:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VKXxy-0006N8-5s for qemu-devel@nongnu.org; Fri, 13 Sep 2013 14:19:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35930) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKXxx-0006N4-SV for qemu-devel@nongnu.org; Fri, 13 Sep 2013 14:19:38 -0400 Message-ID: <52335729.7030306@redhat.com> Date: Fri, 13 Sep 2013 12:19:21 -0600 From: Eric Blake MIME-Version: 1.0 References: <1379067909-22984-1-git-send-email-pl@kamp.de> <1379067909-22984-7-git-send-email-pl@kamp.de> In-Reply-To: <1379067909-22984-7-git-send-email-pl@kamp.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LDamQUOUMSQnP20lePnX5X8wgxLrckFIS" Subject: Re: [Qemu-devel] [PATCH 06/12] iscsi: add .bdrv_get_info List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: kwolf@redhat.com, ronniesahlberg@gmail.com, stefanha@redhat.com, qemu-devel@nongnu.org, anthony@codemonkey.ws, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LDamQUOUMSQnP20lePnX5X8wgxLrckFIS Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/13/2013 04:25 AM, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > block/iscsi.c | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) >=20 > + > + bdi->discard_zeroes =3D iscsilun->lbprz; > + bdi->discard_write_zeroes =3D (bs->open_flags & BDRV_O_UNMAP) && Why two spaces after =3D (two instances)? But that's cosmetic, so you can fix before adding: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --LDamQUOUMSQnP20lePnX5X8wgxLrckFIS Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSM1cpAAoJEKeha0olJ0Nqd4cH/2jetvgUfp4DguYXzwqWA1P7 appvdfCq+rSnYw4/RPaKuDLPwJH5D2fhANYb1yYCzBA9w6aVJ39RGGjGsn3aINwl JztYz80n3owFNJz/SC5HOQVb+Eq/aEaKeiwK9yMc9XtySgMJ1szhlTOKY4H175Oy ZyJXMV3EH6+nccKeCflg58oaHu2bSHReSLjElvT0qDkSL+BsUxmOV7WP6y93rvX2 2ywnRllLwuoGdlwZa2Qr+fiexcWP7DiU7zNgQuAJTAuwR4e4qK1mqYWGAkzvkc86 uoFJBsBvvLIpkikQrc2ajZiBJsRm1mVUmmU17Gq1onUlL3SGd6WcufHukpI2Fto= =oiWn -----END PGP SIGNATURE----- --LDamQUOUMSQnP20lePnX5X8wgxLrckFIS--