From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43294) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKY6k-00015M-J2 for qemu-devel@nongnu.org; Fri, 13 Sep 2013 14:28:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VKY6g-0000YD-5Q for qemu-devel@nongnu.org; Fri, 13 Sep 2013 14:28:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16970) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKY6f-0000Y9-TP for qemu-devel@nongnu.org; Fri, 13 Sep 2013 14:28:38 -0400 Message-ID: <5233594D.70906@redhat.com> Date: Fri, 13 Sep 2013 12:28:29 -0600 From: Eric Blake MIME-Version: 1.0 References: <1379067909-22984-1-git-send-email-pl@kamp.de> <1379067909-22984-12-git-send-email-pl@kamp.de> In-Reply-To: <1379067909-22984-12-git-send-email-pl@kamp.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IxlFnPF4FvADsjcLtciicBjsgUPPEHQ5J" Subject: Re: [Qemu-devel] [PATCH 11/12] block/get_block_status: avoid redundant callouts on raw devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: kwolf@redhat.com, ronniesahlberg@gmail.com, stefanha@redhat.com, qemu-devel@nongnu.org, anthony@codemonkey.ws, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --IxlFnPF4FvADsjcLtciicBjsgUPPEHQ5J Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/13/2013 04:25 AM, Peter Lieven wrote: > if a raw device like an iscsi target or host device is used > the current implementation makes a second call out to get > the block status of bs->file. however, the raw driver already > has called bdrv_get_block_status on bs->file. >=20 > Signed-off-by: Peter Lieven > --- > block.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake >=20 > diff --git a/block.c b/block.c > index cf9db62..282943b 100644 > --- a/block.c > +++ b/block.c > @@ -3167,7 +3167,8 @@ static int64_t coroutine_fn bdrv_co_get_block_sta= tus(BlockDriverState *bs, > =20 > if (bs->file && > (ret & BDRV_BLOCK_DATA) && !(ret & BDRV_BLOCK_ZERO) && > - (ret & BDRV_BLOCK_OFFSET_VALID)) { > + (ret & BDRV_BLOCK_OFFSET_VALID) && > + strcmp(bs->drv->format_name, "raw")) { > ret2 =3D bdrv_co_get_block_status(bs->file, ret >> BDRV_SECTOR= _BITS, > *pnum, pnum); > if (ret2 >=3D 0) { >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --IxlFnPF4FvADsjcLtciicBjsgUPPEHQ5J Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSM1lNAAoJEKeha0olJ0NqAzIH/0Gf84w19QHqdMFUmBgEUVDk yfY0hhtnhwxwfZ953/RyjvvIpFxouFXjRilXnmGlf96PjcTn0oZ53IttEaQW3g2+ mxtdCNEkjLThB4y6QqXBuoUe2FgoVowvEpMlJv5/Xmx8gK714M+1xtSLSEfIQBLh Ac2SHvoloywhjYkG331dbQAXGQlchVxyImzxX/PBAmbdWoApBZE8utZkPyZy1G+m dmIOJx9kbfpeu8Uac+S8+U2qBYM7CSamk0me9z4v17JK6FdsUuqAUqtKYsNyY/n/ CHG4qvyDmCrMCWZh7CQovDNvSa40P3w7djLpbUlZ0p5XjexVulwfNQeMH9xARiw= =FEni -----END PGP SIGNATURE----- --IxlFnPF4FvADsjcLtciicBjsgUPPEHQ5J--