qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Aurelien Jarno <aurelien@aurel32.net>,
	qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] sh4: Fix serial line access for Linux kernels later than 3.2
Date: Fri, 13 Sep 2013 21:04:41 -0700	[thread overview]
Message-ID: <5233E059.8090402@roeck-us.net> (raw)
In-Reply-To: <1378625945-15525-1-git-send-email-linux@roeck-us.net>

On 09/08/2013 12:39 AM, Guenter Roeck wrote:
> With Linux kernel version 3.3 or later, qemu fails with the following message:
>
> sh_serial: unsupported read from 0x18
>    Aborted
>
> Reported-and-analyzed-by: Rob Landley <rob@landley.net>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

ping ...

> ---
> See http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg03870.html
> for Rob's analysis of the problem. Unfortunately, the patch never made it
> into qemu.
>
>   hw/char/sh_serial.c |    2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/hw/char/sh_serial.c b/hw/char/sh_serial.c
> index 6223a55..9328dd1 100644
> --- a/hw/char/sh_serial.c
> +++ b/hw/char/sh_serial.c
> @@ -248,11 +248,9 @@ static uint64_t sh_serial_read(void *opaque, hwaddr offs,
>                       s->flags &= ~SH_SERIAL_FLAG_RDF;
>               }
>               break;
> -#if 0
>           case 0x18:
>               ret = s->fcr;
>               break;
> -#endif
>           case 0x1c:
>               ret = s->rx_cnt;
>               break;
>

  parent reply	other threads:[~2013-09-14  4:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-08  7:39 [Qemu-devel] [PATCH] sh4: Fix serial line access for Linux kernels later than 3.2 Guenter Roeck
2013-09-08  7:51 ` Peter Maydell
2013-09-08 15:48   ` Guenter Roeck
2013-09-14  4:04 ` Guenter Roeck [this message]
2013-09-29 19:12   ` Paolo Bonzini
2013-09-29 19:52     ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5233E059.8090402@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=aurelien@aurel32.net \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).