From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34644)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <linux@roeck-us.net>) id 1VKh6K-0007zs-J8
	for qemu-devel@nongnu.org; Sat, 14 Sep 2013 00:04:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <linux@roeck-us.net>) id 1VKh6F-0005vw-Ej
	for qemu-devel@nongnu.org; Sat, 14 Sep 2013 00:04:52 -0400
Received: from mail.active-venture.com ([67.228.131.205]:61327)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <linux@roeck-us.net>) id 1VKh6F-0005vi-6f
	for qemu-devel@nongnu.org; Sat, 14 Sep 2013 00:04:47 -0400
Message-ID: <5233E059.8090402@roeck-us.net>
Date: Fri, 13 Sep 2013 21:04:41 -0700
From: Guenter Roeck <linux@roeck-us.net>
MIME-Version: 1.0
References: <1378625945-15525-1-git-send-email-linux@roeck-us.net>
In-Reply-To: <1378625945-15525-1-git-send-email-linux@roeck-us.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] sh4: Fix serial line access for Linux
 kernels later than 3.2
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Aurelien Jarno <aurelien@aurel32.net>, qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>

On 09/08/2013 12:39 AM, Guenter Roeck wrote:
> With Linux kernel version 3.3 or later, qemu fails with the following message:
>
> sh_serial: unsupported read from 0x18
>    Aborted
>
> Reported-and-analyzed-by: Rob Landley <rob@landley.net>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

ping ...

> ---
> See http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg03870.html
> for Rob's analysis of the problem. Unfortunately, the patch never made it
> into qemu.
>
>   hw/char/sh_serial.c |    2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/hw/char/sh_serial.c b/hw/char/sh_serial.c
> index 6223a55..9328dd1 100644
> --- a/hw/char/sh_serial.c
> +++ b/hw/char/sh_serial.c
> @@ -248,11 +248,9 @@ static uint64_t sh_serial_read(void *opaque, hwaddr offs,
>                       s->flags &= ~SH_SERIAL_FLAG_RDF;
>               }
>               break;
> -#if 0
>           case 0x18:
>               ret = s->fcr;
>               break;
> -#endif
>           case 0x1c:
>               ret = s->rx_cnt;
>               break;
>