From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40085) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKull-0005wa-6f for qemu-devel@nongnu.org; Sat, 14 Sep 2013 14:40:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VKulg-0006VW-7w for qemu-devel@nongnu.org; Sat, 14 Sep 2013 14:40:33 -0400 Received: from mail-pb0-x22b.google.com ([2607:f8b0:400e:c01::22b]:45078) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VKulf-0006VK-W8 for qemu-devel@nongnu.org; Sat, 14 Sep 2013 14:40:28 -0400 Received: by mail-pb0-f43.google.com with SMTP id md4so2506724pbc.2 for ; Sat, 14 Sep 2013 11:40:26 -0700 (PDT) Sender: Richard Henderson Message-ID: <5234AD97.3060602@twiddle.net> Date: Sat, 14 Sep 2013 11:40:23 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1379073525-20995-1-git-send-email-hpoussin@reactos.org> In-Reply-To: <1379073525-20995-1-git-send-email-hpoussin@reactos.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] pci: remove explicit check to 64K ioport size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" On 09/13/2013 04:58 AM, Hervé Poussineau wrote: > This check is useless, as bigger addresses will be ignored when > added to 'io' MemoryRegion, which has a size of 64K. > > However, some architectures don't use the 'io' MemoryRegion, like > the alpha and versatile platforms. They create a PCI I/O region > bigger than 64K, so let them handle PCI I/O BARs in the higher range. > > Signed-off-by: Hervé Poussineau > --- > hw/pci/pci.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Richard Henderson r~