From: Stefan Weil <sw@weilnetz.de>
To: Richard Henderson <rth@twiddle.net>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org,
aurelien@aurel32.net, Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 3/8] target-m68k: Rename helpers.h to helper.h
Date: Sun, 15 Sep 2013 08:35:40 +0200 [thread overview]
Message-ID: <5235553C.5000400@weilnetz.de> (raw)
In-Reply-To: <1379203434-5680-4-git-send-email-rth@twiddle.net>
Am 15.09.2013 02:03, schrieb Richard Henderson:
> This brings the m68k target in line with all other targets.
>
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
> target-m68k/helper.c | 2 +-
> target-m68k/{helpers.h => helper.h} | 0
> target-m68k/op_helper.c | 2 +-
> target-m68k/translate.c | 6 +++---
> 4 files changed, 5 insertions(+), 5 deletions(-)
> rename target-m68k/{helpers.h => helper.h} (100%)
>
> diff --git a/target-m68k/helper.c b/target-m68k/helper.c
> index 00a7a08..a508896 100644
> --- a/target-m68k/helper.c
> +++ b/target-m68k/helper.c
> @@ -21,7 +21,7 @@
> #include "cpu.h"
> #include "exec/gdbstub.h"
>
> -#include "helpers.h"
> +#include "helper.h"
>
> #define SIGNBIT (1u << 31)
>
> diff --git a/target-m68k/helpers.h b/target-m68k/helper.h
> similarity index 100%
> rename from target-m68k/helpers.h
> rename to target-m68k/helper.h
> diff --git a/target-m68k/op_helper.c b/target-m68k/op_helper.c
> index 30f7d8b..bbbfd7f 100644
> --- a/target-m68k/op_helper.c
> +++ b/target-m68k/op_helper.c
> @@ -17,7 +17,7 @@
> * License along with this library; if not, see <http://www.gnu.org/licenses/>.
> */
> #include "cpu.h"
> -#include "helpers.h"
> +#include "helper.h"
>
> #if defined(CONFIG_USER_ONLY)
>
> diff --git a/target-m68k/translate.c b/target-m68k/translate.c
> index 0be0a96..f31e48d 100644
> --- a/target-m68k/translate.c
> +++ b/target-m68k/translate.c
> @@ -23,9 +23,9 @@
> #include "tcg-op.h"
> #include "qemu/log.h"
>
> -#include "helpers.h"
> +#include "helper.h"
> #define GEN_HELPER 1
> -#include "helpers.h"
> +#include "helper.h"
>
> //#define DEBUG_DISPATCH 1
>
> @@ -110,7 +110,7 @@ void m68k_tcg_init(void)
> store_dummy = tcg_global_mem_new(TCG_AREG0, -8, "NULL");
>
> #define GEN_HELPER 2
> -#include "helpers.h"
> +#include "helper.h"
> }
>
> static inline void qemu_assert(int cond, const char *msg)
Reviewed-by: Stefan Weil <sw@weilnetz.de>
next prev parent reply other threads:[~2013-09-15 6:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-15 0:03 [Qemu-devel] [PATCH 0/8] tcg: Tidy helpers registration Richard Henderson
2013-09-15 0:03 ` [Qemu-devel] [PATCH 1/8] tcg: Delete tcg_helper_get_name declaration Richard Henderson
2013-09-15 6:14 ` Stefan Weil
2013-09-15 0:03 ` [Qemu-devel] [PATCH 2/8] tcg: Use a GHashTable for tcg_find_helper Richard Henderson
2013-09-15 6:32 ` Stefan Weil
2013-09-15 0:03 ` [Qemu-devel] [PATCH 3/8] target-m68k: Rename helpers.h to helper.h Richard Henderson
2013-09-15 6:35 ` Stefan Weil [this message]
2013-09-15 0:03 ` [Qemu-devel] [PATCH 4/8] tcg: Move helper registration into tcg_context_init Richard Henderson
2013-09-15 0:03 ` [Qemu-devel] [PATCH 5/8] tcg: Remove stray semi-colons from target-*/helper.h Richard Henderson
2013-09-15 7:03 ` Stefan Weil
2013-09-15 10:44 ` Peter Maydell
2013-09-15 0:03 ` [Qemu-devel] [PATCH 6/8] tcg: Put target helper data into an array Richard Henderson
2013-09-15 0:03 ` [Qemu-devel] [PATCH 7/8] tcg: Add tcg-runtime.c helpers to all_helpers Richard Henderson
2013-09-15 0:03 ` [Qemu-devel] [PATCH 8/8] tcg: Merge tcg_register_helper into tcg_context_init Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5235553C.5000400@weilnetz.de \
--to=sw@weilnetz.de \
--cc=aurelien@aurel32.net \
--cc=paul@codesourcery.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).