From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41495)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1VLZFL-0001Km-Jw
	for qemu-devel@nongnu.org; Mon, 16 Sep 2013 09:53:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1VLZFC-0004pA-M7
	for qemu-devel@nongnu.org; Mon, 16 Sep 2013 09:53:47 -0400
Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:54974)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1VLZFC-0004oc-Bm
	for qemu-devel@nongnu.org; Mon, 16 Sep 2013 09:53:38 -0400
Received: from /spool/local
	by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <borntraeger@de.ibm.com>;
	Mon, 16 Sep 2013 14:47:52 +0100
Received: from b06cxnps3075.portsmouth.uk.ibm.com
	(d06relay10.portsmouth.uk.ibm.com [9.149.109.195])
	by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id ADC8E219005E
	for <qemu-devel@nongnu.org>; Mon, 16 Sep 2013 14:53:33 +0100 (BST)
Received: from d06av12.portsmouth.uk.ibm.com (d06av12.portsmouth.uk.ibm.com
	[9.149.37.247])
	by b06cxnps3075.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with
	ESMTP id r8GDrLnl197062
	for <qemu-devel@nongnu.org>; Mon, 16 Sep 2013 13:53:21 GMT
Received: from d06av12.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av12.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id r8GDrWib014003
	for <qemu-devel@nongnu.org>; Mon, 16 Sep 2013 07:53:33 -0600
Message-ID: <52370D59.9070508@de.ibm.com>
Date: Mon, 16 Sep 2013 15:53:29 +0200
From: Christian Borntraeger <borntraeger@de.ibm.com>
MIME-Version: 1.0
References: <1375366359-11553-1-git-send-email-jjherne@us.ibm.com>
	<1375366359-11553-2-git-send-email-jjherne@us.ibm.com>
	<83627597-537A-4370-88C0-A7057ECCC99F@suse.de>
In-Reply-To: <83627597-537A-4370-88C0-A7057ECCC99F@suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/8] [PATCH RFC v3] s390-qemu: cpu hotplug
 - Define New SCLP Codes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: ehabkost@redhat.com, qemu-devel@nongnu.org, "Jason J.Herne" <jjherne@us.ibm.com>, jfrei@linux.vnet.ibm.com, imammedo@redhat.com, afaerber@suse.de

On 05/09/13 13:25, Alexander Graf wrote:
> 
> On 01.08.2013, at 16:12, Jason J. Herne wrote:
> 
>> From: "Jason J. Herne" <jjherne@us.ibm.com>
>>
>> Define new SCLP codes to improve code readability.
>>
>> Signed-off-by: Jason J. Herne <jjherne@us.ibm.com>
>> ---
>> hw/s390x/sclp.c         |    2 +-
>> include/hw/s390x/sclp.h |    8 ++++++++
>> 2 files changed, 9 insertions(+), 1 deletion(-)
>>
>> diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c
>> index 86d6ae0..cb53d7e 100644
>> --- a/hw/s390x/sclp.c
>> +++ b/hw/s390x/sclp.c
>> @@ -45,7 +45,7 @@ static void sclp_execute(SCCB *sccb, uint64_t code)
>> {
>>     S390SCLPDevice *sdev = get_event_facility();
>>
>> -    switch (code) {
>> +    switch (code & SCLP_NO_CMD_PARM) {
> 
> switch (code & ~SCLP_CMD_PARM)
> 
> Or are the upper bits parm as well? In fact, what about the upper 32 bits?

As of now those are ignored by the sclp. So (code & SCLP_NO_CMD_PARM) seems
better to me.