From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52451) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VLZoo-0000cp-3Z for qemu-devel@nongnu.org; Mon, 16 Sep 2013 10:30:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VLZof-00004r-00 for qemu-devel@nongnu.org; Mon, 16 Sep 2013 10:30:26 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:59292) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VLZoe-0008W4-PQ for qemu-devel@nongnu.org; Mon, 16 Sep 2013 10:30:16 -0400 Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 16 Sep 2013 08:30:15 -0600 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id EE0AA1FF001A for ; Mon, 16 Sep 2013 08:30:07 -0600 (MDT) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r8GEU7iU237310 for ; Mon, 16 Sep 2013 08:30:08 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r8GET3SP002727 for ; Mon, 16 Sep 2013 08:29:04 -0600 Message-ID: <523715AE.4010406@linux.vnet.ibm.com> Date: Mon, 16 Sep 2013 10:29:02 -0400 From: "Jason J. Herne" MIME-Version: 1.0 References: <1375366359-11553-1-git-send-email-jjherne@us.ibm.com> <1375366359-11553-2-git-send-email-jjherne@us.ibm.com> <83627597-537A-4370-88C0-A7057ECCC99F@suse.de> <52370D59.9070508@de.ibm.com> In-Reply-To: <52370D59.9070508@de.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/8] [PATCH RFC v3] s390-qemu: cpu hotplug - Define New SCLP Codes Reply-To: jjherne@linux.vnet.ibm.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger Cc: Alexander Graf , ehabkost@redhat.com, qemu-devel@nongnu.org, "Jason J.Herne" , jfrei@linux.vnet.ibm.com, imammedo@redhat.com, afaerber@suse.de On 09/16/2013 09:53 AM, Christian Borntraeger wrote: > On 05/09/13 13:25, Alexander Graf wrote: >> >> On 01.08.2013, at 16:12, Jason J. Herne wrote: >> >>> From: "Jason J. Herne" >>> >>> Define new SCLP codes to improve code readability. >>> >>> Signed-off-by: Jason J. Herne >>> --- >>> hw/s390x/sclp.c | 2 +- >>> include/hw/s390x/sclp.h | 8 ++++++++ >>> 2 files changed, 9 insertions(+), 1 deletion(-) >>> >>> diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c >>> index 86d6ae0..cb53d7e 100644 >>> --- a/hw/s390x/sclp.c >>> +++ b/hw/s390x/sclp.c >>> @@ -45,7 +45,7 @@ static void sclp_execute(SCCB *sccb, uint64_t code) >>> { >>> S390SCLPDevice *sdev = get_event_facility(); >>> >>> - switch (code) { >>> + switch (code & SCLP_NO_CMD_PARM) { >> >> switch (code & ~SCLP_CMD_PARM) >> >> Or are the upper bits parm as well? In fact, what about the upper 32 bits? > > As of now those are ignored by the sclp. So (code & SCLP_NO_CMD_PARM) seems > better to me. > > > > What if I rename it to SCLP_CMD_CODE_MASK? This removes the negative from the name and keeps the same semantics. -- -- Jason J. Herne (jjherne@linux.vnet.ibm.com)