From: Paolo Bonzini <pbonzini@redhat.com>
To: Sebastian Ottlik <ottlik@fzi.de>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 0/5] Do not set SO_REUSEADDR on Windows
Date: Mon, 16 Sep 2013 16:55:07 +0200 [thread overview]
Message-ID: <52371BCB.4090004@redhat.com> (raw)
In-Reply-To: <1379341429-29141-1-git-send-email-ottlik@fzi.de>
Il 16/09/2013 16:23, Sebastian Ottlik ha scritto:
> - Added the silent flag to socket_set_fast_reuse controlling error reporting
> One location where SO_REUSEADDR was set would report errors if setting the
> option failed. Keeping the reporting code there would be somewhat unclean, so
> I moved it to socket_set_fast_reuse. A side effect of this was that the error
> reporting was added for all locations that now use socket_set_fast_reuse. Here
> a new flag is added to control error reporting, which means this patchset
> won't change QEMU behaviour (except for not setting SO_REUSEADDR on Windows).
Is there actually a case where setting SO_REUSEADDR could fail?
Paolo
next prev parent reply other threads:[~2013-09-16 14:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 14:23 [Qemu-devel] [PATCH v5 0/5] Do not set SO_REUSEADDR on Windows Sebastian Ottlik
2013-09-16 14:23 ` [Qemu-devel] [PATCH v5 1/5] util: add socket_set_fast_reuse function which will replace setting SO_REUSEADDR Sebastian Ottlik
2013-09-16 14:23 ` [Qemu-devel] [PATCH v5 2/5] gdbstub: call socket_set_fast_reuse instead of " Sebastian Ottlik
2013-09-16 14:23 ` [Qemu-devel] [PATCH v5 3/5] net: " Sebastian Ottlik
2013-09-16 14:23 ` [Qemu-devel] [PATCH v5 4/5] slirp: " Sebastian Ottlik
2013-09-16 14:23 ` [Qemu-devel] [PATCH v5 5/5] util: " Sebastian Ottlik
2013-09-16 14:55 ` Paolo Bonzini [this message]
2013-09-16 15:10 ` [Qemu-devel] [PATCH v5 0/5] Do not set SO_REUSEADDR on Windows Sebastian Ottlik
2013-09-18 16:58 ` Stefan Weil
2013-09-23 10:33 ` Sebastian Ottlik
2013-10-01 8:11 ` Sebastian Ottlik
2013-10-01 16:44 ` Stefan Weil
2013-09-18 12:42 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52371BCB.4090004@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=jan.kiszka@siemens.com \
--cc=ottlik@fzi.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).