From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59002) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VLaCh-0001Wz-Dv for qemu-devel@nongnu.org; Mon, 16 Sep 2013 10:55:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VLaCY-0007l9-FO for qemu-devel@nongnu.org; Mon, 16 Sep 2013 10:55:07 -0400 Received: from mail-yh0-x230.google.com ([2607:f8b0:4002:c01::230]:51372) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VLaCY-0007kv-BM for qemu-devel@nongnu.org; Mon, 16 Sep 2013 10:54:58 -0400 Received: by mail-yh0-f48.google.com with SMTP id f10so2067609yha.21 for ; Mon, 16 Sep 2013 07:54:57 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <52371BCB.4090004@redhat.com> Date: Mon, 16 Sep 2013 16:55:07 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1379341429-29141-1-git-send-email-ottlik@fzi.de> In-Reply-To: <1379341429-29141-1-git-send-email-ottlik@fzi.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 0/5] Do not set SO_REUSEADDR on Windows List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sebastian Ottlik Cc: Jan Kiszka , Anthony Liguori , qemu-devel@nongnu.org, Stefan Hajnoczi Il 16/09/2013 16:23, Sebastian Ottlik ha scritto: > - Added the silent flag to socket_set_fast_reuse controlling error reporting > One location where SO_REUSEADDR was set would report errors if setting the > option failed. Keeping the reporting code there would be somewhat unclean, so > I moved it to socket_set_fast_reuse. A side effect of this was that the error > reporting was added for all locations that now use socket_set_fast_reuse. Here > a new flag is added to control error reporting, which means this patchset > won't change QEMU behaviour (except for not setting SO_REUSEADDR on Windows). Is there actually a case where setting SO_REUSEADDR could fail? Paolo