From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60028) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VLaHW-00035b-5C for qemu-devel@nongnu.org; Mon, 16 Sep 2013 11:00:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VLaHN-0000pQ-8H for qemu-devel@nongnu.org; Mon, 16 Sep 2013 11:00:06 -0400 Received: from e8.ny.us.ibm.com ([32.97.182.138]:55419) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VLaHN-0000pH-40 for qemu-devel@nongnu.org; Mon, 16 Sep 2013 10:59:57 -0400 Received: from /spool/local by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 16 Sep 2013 10:59:56 -0400 Received: from b01cxnp23032.gho.pok.ibm.com (b01cxnp23032.gho.pok.ibm.com [9.57.198.27]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 5646DC9005C for ; Mon, 16 Sep 2013 10:59:51 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by b01cxnp23032.gho.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r8GExo9u55378138 for ; Mon, 16 Sep 2013 14:59:50 GMT Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r8GExmWV025229 for ; Mon, 16 Sep 2013 10:59:49 -0400 Message-ID: <52371CE2.8040100@linux.vnet.ibm.com> Date: Mon, 16 Sep 2013 10:59:46 -0400 From: "Jason J. Herne" MIME-Version: 1.0 References: <1375366359-11553-1-git-send-email-jjherne@us.ibm.com> <1375366359-11553-2-git-send-email-jjherne@us.ibm.com> <83627597-537A-4370-88C0-A7057ECCC99F@suse.de> <52370D59.9070508@de.ibm.com> <523715AE.4010406@linux.vnet.ibm.com> <66D05DD8-6EC9-49EB-88EC-DA82864F0D6C@suse.de> In-Reply-To: <66D05DD8-6EC9-49EB-88EC-DA82864F0D6C@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/8] [PATCH RFC v3] s390-qemu: cpu hotplug - Define New SCLP Codes Reply-To: jjherne@linux.vnet.ibm.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: "ehabkost@redhat.com" , "Jason J.Herne" , "qemu-devel@nongnu.org" , Christian Borntraeger , "jfrei@linux.vnet.ibm.com" , "imammedo@redhat.com" , "afaerber@suse.de" On 09/16/2013 10:43 AM, Alexander Graf wrote: > > > Am 16.09.2013 um 09:29 schrieb "Jason J. Herne" : > >> On 09/16/2013 09:53 AM, Christian Borntraeger wrote: >>> On 05/09/13 13:25, Alexander Graf wrote: >>>> >>>> On 01.08.2013, at 16:12, Jason J. Herne wrote: >>>> >>>>> From: "Jason J. Herne" >>>>> >>>>> Define new SCLP codes to improve code readability. >>>>> >>>>> Signed-off-by: Jason J. Herne >>>>> --- >>>>> hw/s390x/sclp.c | 2 +- >>>>> include/hw/s390x/sclp.h | 8 ++++++++ >>>>> 2 files changed, 9 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c >>>>> index 86d6ae0..cb53d7e 100644 >>>>> --- a/hw/s390x/sclp.c >>>>> +++ b/hw/s390x/sclp.c >>>>> @@ -45,7 +45,7 @@ static void sclp_execute(SCCB *sccb, uint64_t code) >>>>> { >>>>> S390SCLPDevice *sdev = get_event_facility(); >>>>> >>>>> - switch (code) { >>>>> + switch (code & SCLP_NO_CMD_PARM) { >>>> >>>> switch (code & ~SCLP_CMD_PARM) >>>> >>>> Or are the upper bits parm as well? In fact, what about the upper 32 bits? >>> >>> As of now those are ignored by the sclp. So (code & SCLP_NO_CMD_PARM) seems >>> better to me. >> >> What if I rename it to SCLP_CMD_CODE_MASK? This removes the negative from the name and keeps the same semantics. > > Does the mask include payload information as well or only the cmd code? > It contains all elements of the command code and nothing more. > >> >> -- >> -- Jason J. Herne (jjherne@linux.vnet.ibm.com) >> > > > -- -- Jason J. Herne (jjherne@linux.vnet.ibm.com)