From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33965)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VLaPF-00087a-63
	for qemu-devel@nongnu.org; Mon, 16 Sep 2013 11:08:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VLaP6-0003ex-PJ
	for qemu-devel@nongnu.org; Mon, 16 Sep 2013 11:08:05 -0400
Received: from mail-oa0-x233.google.com ([2607:f8b0:4003:c02::233]:52329)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VLaP6-0003er-IT
	for qemu-devel@nongnu.org; Mon, 16 Sep 2013 11:07:56 -0400
Received: by mail-oa0-f51.google.com with SMTP id l6so110383oag.38
	for <qemu-devel@nongnu.org>; Mon, 16 Sep 2013 08:07:56 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52371EC7.60501@twiddle.net>
Date: Mon, 16 Sep 2013 08:07:51 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1379195690-6509-1-git-send-email-rth@twiddle.net>
	<1379195690-6509-4-git-send-email-rth@twiddle.net>
	<5236B71F.2080807@huawei.com>
In-Reply-To: <5236B71F.2080807@huawei.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 03/33] tcg-aarch64: Don't handle
 mov/movi in tcg_out_op
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Claudio Fontana <claudio.fontana@huawei.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org

On 09/16/2013 12:45 AM, Claudio Fontana wrote:
>> >      default:
>> > -        tcg_abort(); /* opcode not implemented */
>> > +        /* Opcode not implemented.  */
>> > +        tcg_abort();
>> >      }
>> >  }
> This change above seems unnecessary.

Perhaps qemu doesn't have the same "comments are sentences" rule that gcc does,
but I still aim to follow it.


r~