From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VLcD1-000474-VC for qemu-devel@nongnu.org; Mon, 16 Sep 2013 13:03:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VLcCv-0008O2-1U for qemu-devel@nongnu.org; Mon, 16 Sep 2013 13:03:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32180) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VLcCu-0008Nw-PS for qemu-devel@nongnu.org; Mon, 16 Sep 2013 13:03:28 -0400 Message-ID: <523739E8.9060204@redhat.com> Date: Mon, 16 Sep 2013 19:03:36 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20130915172331.GA2821@redhat.com> <5236A5ED.3000804@suse.de> <20130916123303.GA2992@redhat.com> <523722BE.90202@suse.de> <20130916154851.GB4141@redhat.com> <52372A48.1040803@redhat.com> <20130916160127.GD4141@redhat.com> <52372CC5.8090408@redhat.com> <20130916165150.GB4386@redhat.com> In-Reply-To: <20130916165150.GB4386@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qom: helper macro for adding read-only properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Igor Mammedov , Stefan Hajnoczi , =?ISO-8859-1?Q?Andreas_F=E4rber?= , Anthony Liguori , qemu-devel@nongnu.org Il 16/09/2013 18:51, Michael S. Tsirkin ha scritto: >> > >> > We can have "make check" run QEMU once for each board, which would trap >> > things that will always break at runtime such as a misspelled property. >> > Similarly, we could have tests that try to instantiate every device, >> > even if they do not do anything with the guest-visible device. Such >> > dummy tests can catch bugs in interface changes. > They won't catch bugs for properties that > 1. change after device is instanciated > 2. are accessed after device is instanciated True, but I don't think there are any at this time if you s/instantiated/realized/. Paolo