From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43575)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sebastian.huber@embedded-brains.de>)
	id 1VLpwd-0007pq-VB
	for qemu-devel@nongnu.org; Tue, 17 Sep 2013 03:43:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sebastian.huber@embedded-brains.de>)
	id 1VLpwV-0000Xi-RO
	for qemu-devel@nongnu.org; Tue, 17 Sep 2013 03:43:35 -0400
Received: from host-82-135-62-35.customer.m-online.net ([82.135.62.35]:53498
	helo=mail.embedded-brains.de) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sebastian.huber@embedded-brains.de>)
	id 1VLpwV-0000XS-JV
	for qemu-devel@nongnu.org; Tue, 17 Sep 2013 03:43:27 -0400
Message-ID: <52380818.4070706@embedded-brains.de>
Date: Tue, 17 Sep 2013 09:43:20 +0200
From: Sebastian Huber <sebastian.huber@embedded-brains.de>
MIME-Version: 1.0
References: <cover.1373429432.git.peter.crosthwaite@xilinx.com>
	<8549a20530b9331af1c3d725f4cb9a3e4fe3a9b2.1373429432.git.peter.crosthwaite@xilinx.com>
In-Reply-To: <8549a20530b9331af1c3d725f4cb9a3e4fe3a9b2.1373429432.git.peter.crosthwaite@xilinx.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v1 4/4] target-arm: Add CP15 VBAR support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: peter.crosthwaite@xilinx.com
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org

On 2013-07-10 06:23, peter.crosthwaite@xilinx.com wrote:
> +static int vbar_write(CPUARMState *env, const ARMCPRegInfo *ri,
> +                      uint64_t value)
> +{
> +    value &=3D (1 << 31);

Is the above correct?

> +    env->cp15.c12_vbar =3D value & ~0x1Ful;
> +    return 0;
> +}

Shouldn't this be

{
   env->cp15.c12_vbar =3D (uint32_t) (value & ~0x1FUL);
   return 0;
}

?

--=20
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber@embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine gesch=E4ftliche Mitteilung im Sinne des EHUG.