From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46120) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VLq8o-0002xL-S1 for qemu-devel@nongnu.org; Tue, 17 Sep 2013 03:56:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VLq8h-0004Df-86 for qemu-devel@nongnu.org; Tue, 17 Sep 2013 03:56:10 -0400 Received: from lhrrgout.huawei.com ([194.213.3.17]:51588) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VLq8g-0004Cy-VE for qemu-devel@nongnu.org; Tue, 17 Sep 2013 03:56:03 -0400 Message-ID: <52380AE6.40007@huawei.com> Date: Tue, 17 Sep 2013 09:55:18 +0200 From: Claudio Fontana MIME-Version: 1.0 References: <1379195690-6509-1-git-send-email-rth@twiddle.net> <1379195690-6509-23-git-send-email-rth@twiddle.net> <5236CC6D.40901@huawei.com> <523728D1.6060600@twiddle.net> In-Reply-To: <523728D1.6060600@twiddle.net> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 22/33] tcg-aarch64: Use MOVN in tcg_out_movi List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org On 16.09.2013 17:50, Richard Henderson wrote: > On 09/16/2013 02:16 AM, Claudio Fontana wrote: >> I agree in general with the approach "lets see if it is more convenient to start with MOVN". >> The existing implementation is, although not easy, leaner. >> Can we make it a little this one a little bit leaner? > > This sentence is not well formed. What did you mean? > > In what sense did you mean "lean"? Smaller or faster? > If faster, see the comment about using neon insns. > If smaller... um... why? I am not suggesting implementing the neon insns based thing. I am suggesting looking at ways to reduce the size and complexity of the code needed to implement the same thing you just posted. If you don't see the why, there is probably little I can say to change that.