From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57701)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Claudio.Fontana@huawei.com>) id 1VLr1I-0006sZ-Uj
	for qemu-devel@nongnu.org; Tue, 17 Sep 2013 04:52:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Claudio.Fontana@huawei.com>) id 1VLr1B-0004cK-NV
	for qemu-devel@nongnu.org; Tue, 17 Sep 2013 04:52:28 -0400
Received: from lhrrgout.huawei.com ([194.213.3.17]:6347)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Claudio.Fontana@huawei.com>) id 1VLr1B-0004cF-Eu
	for qemu-devel@nongnu.org; Tue, 17 Sep 2013 04:52:21 -0400
Message-ID: <52381804.20902@huawei.com>
Date: Tue, 17 Sep 2013 10:51:16 +0200
From: Claudio Fontana <claudio.fontana@huawei.com>
MIME-Version: 1.0
References: <1379195690-6509-1-git-send-email-rth@twiddle.net>
	<1379195690-6509-7-git-send-email-rth@twiddle.net>
	<5236B9C1.2070109@huawei.com> <52371E65.7070804@twiddle.net>
In-Reply-To: <52371E65.7070804@twiddle.net>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 06/33] tcg-aarch64: Merge enum
 aarch64_srr_opc with AArch64Insn
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org

On 16.09.2013 17:06, Richard Henderson wrote:
> On 09/16/2013 12:56 AM, Claudio Fontana wrote:
>>>>      case INDEX_op_shl_i64:
>>>>      case INDEX_op_shl_i32:
>>>> -        if (c2) {    /* LSL / UBFM Wd, Wn, (32 - m) */
>>>> +        if (c2) {
>>>>              tcg_out_shl(s, ext, a0, a1, a2);
>>>> -        } else {                /* LSL / LSLV */
>>>> -            tcg_out_shiftrot_reg(s, SRR_SHL, ext, a0, a1, a2);
>>>> +        } else {
>>>> +            tcg_out_shiftrot_reg(s, INSN_LSLV, ext, a0, a1, a2);
>>>>          }
>>>>          break;
>> Any reason you strip all comments out?
>> They are supposed to hint the reader about how the tcg operation is implemented.
>>
> 
> Well, LSLV is now there in the code in the form of INSN_LSLV.  The comment does
> nothing additional to hint at what's going on; indeed, "LSL / LSLV" is more
> confusing than not.
> 
> As for tcg_out_shl, comments about its implementation are with that function.
> 
> 

Fair enough.

C.