From: Alexander Graf <agraf@suse.de>
To: Thomas Huth <thuth@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>,
"qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>
Subject: Re: [Qemu-devel] should we update QEMU's u-boot submodule and binary?
Date: Wed, 12 Jul 2017 12:56:56 +0200 [thread overview]
Message-ID: <52384cdc-7a38-876f-b1a8-e00b19c7f158@suse.de> (raw)
In-Reply-To: <3d688e8e-1140-557b-d2ed-1d96e6f5831a@redhat.com>
On 12.07.17 12:49, Thomas Huth wrote:
> On 12.07.2017 12:44, Alexander Graf wrote:
>>
>>
>> On 12.07.17 12:34, Thomas Huth wrote:
>>> On 11.07.2017 20:22, Alexander Graf wrote:
>>>>
>>>> On 11.07.17 19:43, Peter Maydell wrote:
>>>>> Hi; I just noticed that our u-boot submodule is still stuck on
>>>>> a commit from 2014 when it was first added to QEMU. Should we
>>>>> move this forward to some more recent u-boot release?
>>>>>
>>>>> I think we only use this for our ppc e500 rom...
>>>>
>>>> It probably makes sense to update the e500 rom and bump the submodule to
>>>> the latest U-Boot release along the way, yes.
>>>>
>>>> U-Boot 2017.07 just got released, so now is quite a good point in time
>>>> to do so.
>>>
>>> I think we should rather update the submodule to commit 79c884d7e4 since
>>> that is the level that is used for the pc-bios/u-boot.e500 binary (see
>>> http://git.qemu.org/?p=qemu.git;a=commitdiff;h=d4574435a6530bbd96ae13 ).
>>
>> Why not update both?
>
> Because it needs some proper tests in that case...?
>
>>> The problematic mv_gen_reg.h is also not part of that commit level
>>> anymore.
>>>
>>> Alex, could you please send a patch for the update? Or shall I prepare
>>> one?
>>
>> I tried to compile U-Boot from 2017.07 earlier, but don't have a working
>> ppc build environment anymore :(
>
> I've never been into that e500 stuff, so I also do not have a proper
> test environment for that embedded ppc stuff ==> let's update just the
> submodule to 79c884d7e4 and call it a day?
You don't need much of a test environment. Just check if it comes up in
QEMU :).
Alex
next prev parent reply other threads:[~2017-07-12 10:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 17:43 [Qemu-devel] should we update QEMU's u-boot submodule and binary? Peter Maydell
2017-07-11 18:22 ` Alexander Graf
2017-07-12 10:34 ` Thomas Huth
2017-07-12 10:44 ` Alexander Graf
2017-07-12 10:49 ` Thomas Huth
2017-07-12 10:56 ` Alexander Graf [this message]
2017-07-12 11:12 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52384cdc-7a38-876f-b1a8-e00b19c7f158@suse.de \
--to=agraf@suse.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).