From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51688)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VLyxY-0006TN-IW
	for qemu-devel@nongnu.org; Tue, 17 Sep 2013 13:21:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VLyxS-0004Bd-Hq
	for qemu-devel@nongnu.org; Tue, 17 Sep 2013 13:21:08 -0400
Received: from mx1.redhat.com ([209.132.183.28]:2533)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1VLyxS-0004BX-8K
	for qemu-devel@nongnu.org; Tue, 17 Sep 2013 13:21:02 -0400
Message-ID: <52388F81.7030102@redhat.com>
Date: Tue, 17 Sep 2013 19:21:05 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1378984634-765-1-git-send-email-pbonzini@redhat.com>
	<1378984634-765-9-git-send-email-pbonzini@redhat.com>
	<52388EF5.4030108@weilnetz.de>
In-Reply-To: <52388EF5.4030108@weilnetz.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PULL 08/11] iscsi: add .bdrv_get_block_status
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>
Cc: Peter Lieven <pl@kamp.de>, qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>

Il 17/09/2013 19:18, Stefan Weil ha scritto:
> Latest QEMU git is broken on Debian wheezy:
>=20
> block/iscsi.c: In function =E2=80=98iscsi_co_get_block_status=E2=80=99:
> block/iscsi.c:842:5: error: implicit declaration of function
> =E2=80=98iscsi_get_lba_status_task=E2=80=99 [-Werror=3Dimplicit-functio=
n-declaration]
> block/iscsi.c:842:5: error: nested extern declaration of
> =E2=80=98iscsi_get_lba_status_task=E2=80=99 [-Werror=3Dnested-externs]
> block/iscsi.c:845:43: error: comparison between pointer and integer
> [-Werror]
> block/iscsi.c:877:18: error: dereferencing pointer to incomplete type
> block/iscsi.c:879:55: error: dereferencing pointer to incomplete type
> block/iscsi.c:884:34: error: dereferencing pointer to incomplete type
> block/iscsi.c:889:14: error: dereferencing pointer to incomplete type
> block/iscsi.c:889:32: error: =E2=80=98SCSI_PROVISIONING_TYPE_DEALLOCATE=
D=E2=80=99
> undeclared (first use in this function)
> block/iscsi.c:889:32: note: each undeclared identifier is reported only
> once for each function it appears in
> block/iscsi.c:890:14: error: dereferencing pointer to incomplete type
> block/iscsi.c:890:32: error: =E2=80=98SCSI_PROVISIONING_TYPE_ANCHORED=E2=
=80=99
> undeclared (first use in this function)
> cc1: all warnings being treated as errors
>=20
> Debian includes libiscsi-dev 1.4.0 without a libiscsi.pk, so it uses a
> compile test
> which thinks that libiscsi is good enough.
>=20
> Did the latest changes raise the requirements for libscsi?

Looks like.  Can you make a patch that drops the definition of
iscsi_co_get_block_status if SCSI_PROVISIONING_TYPE_DEALLOCATED is not
#defined?

Thanks,

Paolo