From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37585)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VME0m-0007aU-Er
	for qemu-devel@nongnu.org; Wed, 18 Sep 2013 05:25:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VME0Z-0008Eq-Ld
	for qemu-devel@nongnu.org; Wed, 18 Sep 2013 05:25:28 -0400
Received: from mail-qc0-x22f.google.com ([2607:f8b0:400d:c01::22f]:40224)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1VME0Z-0008EL-Gz
	for qemu-devel@nongnu.org; Wed, 18 Sep 2013 05:25:15 -0400
Received: by mail-qc0-f175.google.com with SMTP id v2so4309987qcr.20
	for <qemu-devel@nongnu.org>; Wed, 18 Sep 2013 02:25:15 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <52397185.9010405@redhat.com>
Date: Wed, 18 Sep 2013 11:25:25 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1376239405-4084-1-git-send-email-alex@alex.org.uk>
	<520A2511.4000709@siemens.com>
	<307AE3B5-FAFE-4E9C-A336-092245809528@alex.org.uk>
	<520A33B4.9030207@siemens.com>
	<14A27B81-C9FD-4EE5-BC4A-7106CD70527A@alex.org.uk>
	<520A3888.9020307@siemens.com>
	<20130813142204.GA3008@stefanha-thinkpad.redhat.com>
	<52387EC2.6000502@siemens.com> <5238810E.1050304@redhat.com>
	<EB842F36-9EDA-48AF-AD4D-412B3AB485AD@alex.org.uk>
	<5238883A.90607@siemens.com> <52388BAA.1060207@redhat.com>
	<6BF1E4A0-946C-402A-9225-0B1DE04DBC54@alex.org.uk>
	<52395CD5.7030203@redhat.com>
	<6DF6BCC2-14BC-4B10-B22E-887D2AFF2012@alex.org.uk>
	<F446CF55-93CB-4B9B-BF89-E36B5352EEE0@alex.org.uk>
In-Reply-To: <F446CF55-93CB-4B9B-BF89-E36B5352EEE0@alex.org.uk>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC] [PATCHv10 00/31] aio / timers: Add
 AioContext timers and use ppoll
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alex Bligh <alex@alex.org.uk>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org, liu ping fan <qemulist@gmail.com>, Stefan Hajnoczi <stefanha@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>, rth@twiddle.net

Il 18/09/2013 11:02, Alex Bligh ha scritto:
> Paolo,
> 
> On 18 Sep 2013, at 09:23, Alex Bligh wrote:
> 
>>> Yes, that was my understanding too.  Can we do it for 1.7?
> 
> Whilst we are changing the calling semantics, do you think
> qemu_coroutine_yield() should also run the timers for the
> aio_context? IE should timers always be deferred to the
> next qemu_aio_wait() / aio_poll(), or should we make it
> so they can run whenever there is a 'schedule' between
> coroutines?

No, they should be left for the next aio_poll().

> I suspect making the change would be trivial. Its
> implications might not be.

Yes, they would not. :)

Paolo