qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Richard Henderson <rth@twiddle.net>
Cc: peter.maydell@linaro.org, famz@redhat.com, mjt@tls.msk.ru,
	qemu-devel@nongnu.org, alex@alex.org.uk, vilanova@ac.upc.edu
Subject: Re: [Qemu-devel] [PATCH v10 5/8] module: implement module loading
Date: Wed, 18 Sep 2013 13:45:10 +0200	[thread overview]
Message-ID: <52399246.4090600@redhat.com> (raw)
In-Reply-To: <5237EB64.9030206@twiddle.net>

Il 17/09/2013 07:40, Richard Henderson ha scritto:
> On 09/16/2013 06:29 PM, Fam Zheng wrote:
>>> Link spice-qemu.char.so against spice-core.so.  The DT_NEEDED entry will be
>>> recorded, and ld.so will do the right thing.
>>>
>>> Anything else sounds way too much like Not Invented Here.
>>>
>> How to do the symbol checking as above if spice-core.so is automatically loaded
>> by ld.so?
> 
> You're checking the version stamp in spice-char.so.  I'd think that's good
> enough.  No need to transitively check.
> 
>> And we will need to add $moddir to LD_LIBRARY_PATH and lose the restriction of
>> modules directory too.
> 
> Or add DT_RUN_PATH to the main executable, or even add DT_RUN_PATH to the
> module itself.  In particular, link the module with
> 
>   -Wl,--enable-new-dtags -Wl,-rpath,'$ORIGIN'
> 
> and dependencies for the module will automatically be looked for in the
> directory in which the module is found.  Which is almost certiainly the only
> thing that we want -- all modules in the same directory.

This is not portable.

It looks like it can be emulated on Windows using LoadLibraryEx with the
LOAD_WITH_ALTERED_SEARCH_PATH flag and passing an absolute path to the
shared library.

But on Mac OS X a bundle (module loaded with dlopen) cannot have a
dependency on another bundle, afaik.

Paolo

  reply	other threads:[~2013-09-18 11:45 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-16  6:50 [Qemu-devel] [PATCH v10 0/8] Shared Library Module Support Fam Zheng
2013-09-16  6:50 ` [Qemu-devel] [PATCH v10 1/8] ui/Makefile.objs: delete unnecessary cocoa.o dependency Fam Zheng
2013-09-16  6:50 ` [Qemu-devel] [PATCH v10 2/8] make.rule: fix $(obj) to a real relative path Fam Zheng
2013-09-16  6:50 ` [Qemu-devel] [PATCH v10 3/8] rule.mak: allow per object cflags and libs Fam Zheng
2013-09-16  6:50 ` [Qemu-devel] [PATCH v10 4/8] build-sys: introduce common-obj-m and block-obj-m for DSO Fam Zheng
2013-09-16  6:50 ` [Qemu-devel] [PATCH v10 5/8] module: implement module loading Fam Zheng
2013-09-16  8:59   ` Daniel P. Berrange
2013-09-16  9:28     ` Fam Zheng
2013-09-16 22:16       ` Richard Henderson
2013-09-17  0:47         ` Fam Zheng
2013-09-16  9:44     ` Paolo Bonzini
2013-09-16  9:51       ` Fam Zheng
2013-09-16 10:09         ` Paolo Bonzini
2013-09-16 10:14           ` Daniel P. Berrange
2013-09-16 10:18             ` Paolo Bonzini
2013-09-16 10:21               ` Daniel P. Berrange
2013-09-16 10:30                 ` Paolo Bonzini
2013-09-16 11:29                   ` Fam Zheng
2013-09-16 11:33                     ` Paolo Bonzini
2013-09-16 11:46                       ` Fam Zheng
2013-09-16 22:31                         ` Richard Henderson
2013-09-17  1:29                           ` Fam Zheng
2013-09-17  5:40                             ` Richard Henderson
2013-09-18 11:45                               ` Paolo Bonzini [this message]
2013-09-18 14:44                                 ` Richard Henderson
2013-09-18 15:00                                   ` Paolo Bonzini
2013-09-17  8:50                     ` Wenchao Xia
2013-09-16 10:57           ` Gerd Hoffmann
2013-09-16 11:00             ` Paolo Bonzini
2013-09-16 22:38               ` Richard Henderson
2013-09-16 10:24         ` Alex Bligh
2013-09-16 10:38           ` Paolo Bonzini
2013-09-16 11:00             ` Alex Bligh
2013-09-16 11:04               ` Daniel P. Berrange
2013-09-16 11:27                 ` Alex Bligh
2013-09-16 11:08               ` Paolo Bonzini
2013-09-16 11:30                 ` Alex Bligh
2013-09-17  8:26             ` Wenchao Xia
2013-09-16 10:43           ` Fam Zheng
2013-09-16 11:05   ` Daniel P. Berrange
2013-09-16 12:36     ` Gerd Hoffmann
2013-09-17  5:55       ` Fam Zheng
2013-09-17  6:33         ` Alex Bligh
2013-09-17  6:40           ` Fam Zheng
2013-09-16  6:50 ` [Qemu-devel] [PATCH v10 6/8] Makefile: install modules with "make install" Fam Zheng
2013-09-16  6:50 ` [Qemu-devel] [PATCH v10 7/8] .gitignore: ignore module related files (dll, so, mo) Fam Zheng
2013-09-16  6:50 ` [Qemu-devel] [PATCH v10 8/8] block: convert block drivers linked with libs to modules Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52399246.4090600@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=alex@alex.org.uk \
    --cc=famz@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=vilanova@ac.upc.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).