From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60369) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMHMU-0003yi-Ua for Qemu-devel@nongnu.org; Wed, 18 Sep 2013 09:00:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VMHMQ-0002w3-1a for Qemu-devel@nongnu.org; Wed, 18 Sep 2013 09:00:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18865) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMHMP-0002s4-Qq for Qemu-devel@nongnu.org; Wed, 18 Sep 2013 09:00:01 -0400 Message-ID: <5239A3CD.7040506@redhat.com> Date: Wed, 18 Sep 2013 06:59:57 -0600 From: Eric Blake MIME-Version: 1.0 References: <1379489038-26041-1-git-send-email-wudxw@linux.vnet.ibm.com> In-Reply-To: <1379489038-26041-1-git-send-email-wudxw@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="LGWDk0qHxQABgq322vaCxBoAkx6oFJtER" Subject: Re: [Qemu-devel] [PATCH] Extend qemu-ga's 'guest-info' command to expose flag 'success-response' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Wu Cc: Luiz Capitulino , Qemu-devel@nongnu.org, Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --LGWDk0qHxQABgq322vaCxBoAkx6oFJtER Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/18/2013 01:23 AM, Mark Wu wrote: > Now we have several qemu-ga commands not returning response on success.= > It has been documented in qga/qapi-schema.json already. This patch expo= ses > the 'success-response' flag by extending 'guest-info' command. With thi= s > change, the clients can handle the command response more flexibly. >=20 > Signed-off-by: Mark Wu > --- > include/qapi/qmp/dispatch.h | 1 + > qapi/qmp-registry.c | 13 +++++++++++++ > qga/commands.c | 2 ++ > qga/qapi-schema.json | 4 +++- > 4 files changed, 19 insertions(+), 1 deletion(-) >=20 > +++ b/qga/qapi-schema.json > @@ -141,10 +141,12 @@ > # > # @enabled: whether command is currently enabled by guest admin > # > +# @success-response: whether command returns a response on success Please add the notation (since 1.7) to this option, to document that it was not present in 1.1.0. Other than that, looks okay to me. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --LGWDk0qHxQABgq322vaCxBoAkx6oFJtER Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSOaPNAAoJEKeha0olJ0NqCD4H+waJhrN0L2lE30QQLWcvYr+f 18lXXPs2XnJngimehdIQSuosfXWbE4EWtiubWOjV0ib5R2P9vtBFp3G9NyYswwo4 8RHgOvEfplyU3dvL4dwi+odaF4tDURJJLnXz/fMK4aX9j8JGm9ogzTtEY8SvMcMq yXgH1Ie2R9p/ahO51254frUNFABc4WC3nxVaCXNQRzXgozsMfvyH8YmWEle3Ar1G KiDqc/4xPdUnDmu/G3jaeLqkzj9vHbos/f0Upf5pUz0SjmcO/XouLnaScqi4I9yQ USgJP9h+SZpiE670FCVMVJc0ukOQsLNOTFyzmKXARmh40yPJAUt+IH9cnqo60zk= =sU4w -----END PGP SIGNATURE----- --LGWDk0qHxQABgq322vaCxBoAkx6oFJtER--