From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49250) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMIIk-0007Ju-Ub for qemu-devel@nongnu.org; Wed, 18 Sep 2013 10:00:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VMIIc-0007ja-Hf for qemu-devel@nongnu.org; Wed, 18 Sep 2013 10:00:18 -0400 Received: from mail-ob0-x229.google.com ([2607:f8b0:4003:c01::229]:58115) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMIIc-0007jO-5W for qemu-devel@nongnu.org; Wed, 18 Sep 2013 10:00:10 -0400 Received: by mail-ob0-f169.google.com with SMTP id wp4so7665459obc.28 for ; Wed, 18 Sep 2013 07:00:09 -0700 (PDT) Sender: Richard Henderson Message-ID: <5239B1E4.6030201@twiddle.net> Date: Wed, 18 Sep 2013 07:00:04 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1379195690-6509-1-git-send-email-rth@twiddle.net> <1379195690-6509-5-git-send-email-rth@twiddle.net> <5236B659.5090608@huawei.com> <52372FD0.7040700@twiddle.net> <52380C53.5060003@huawei.com> <523866BD.1010307@twiddle.net> <52395FDD.8070702@huawei.com> In-Reply-To: <52395FDD.8070702@huawei.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 04/33] tcg-aarch64: Hoist common argument loads in tcg_out_op List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Claudio Fontana Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org On 09/18/2013 01:10 AM, Claudio Fontana wrote: > On 17.09.2013 16:27, Richard Henderson wrote: >> On 09/17/2013 01:01 AM, Claudio Fontana wrote: >>> I don't have anything against it in principle, but just adding c0 and c1, >>> which iirc should cover all uses, would be fine by me. >> >> Not really. >> >> There are 6 potential args[] values, 5 of which might be const_args[]. >> > > Current uses. Like the args[] that are actually used right now. That's what I'm talking about. E.g. movcond: 6 args[], 1-4 are inputs that might have const_args[]. r~