From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53277) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMIb3-0004zo-4o for qemu-devel@nongnu.org; Wed, 18 Sep 2013 10:19:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VMIax-00051u-68 for qemu-devel@nongnu.org; Wed, 18 Sep 2013 10:19:13 -0400 Received: from lhrrgout.huawei.com ([194.213.3.17]:20687) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMIaw-00051l-TI for qemu-devel@nongnu.org; Wed, 18 Sep 2013 10:19:07 -0400 Message-ID: <5239B62A.8030905@huawei.com> Date: Wed, 18 Sep 2013 16:18:18 +0200 From: Claudio Fontana MIME-Version: 1.0 References: <1379195690-6509-1-git-send-email-rth@twiddle.net> <1379195690-6509-5-git-send-email-rth@twiddle.net> <5236B659.5090608@huawei.com> <52372FD0.7040700@twiddle.net> <52380C53.5060003@huawei.com> <523866BD.1010307@twiddle.net> In-Reply-To: <523866BD.1010307@twiddle.net> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 04/33] tcg-aarch64: Hoist common argument loads in tcg_out_op List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org On 17.09.2013 16:27, Richard Henderson wrote: > On 09/17/2013 01:01 AM, Claudio Fontana wrote: >> I don't have anything against it in principle, but just adding c0 and c1, >> which iirc should cover all uses, would be fine by me. > > Not really. > > There are 6 potential args[] values, 5 of which might be const_args[]. > > > r~ Ok adding all of those would be a waste, did not keep the movcond changes into consideration. Your initial proposal was indeed the best tradeoff then, lets just hoist the most commonly used args then. C.