From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57655) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMIkq-00007d-Of for qemu-devel@nongnu.org; Wed, 18 Sep 2013 10:29:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VMIki-0000Yv-S1 for qemu-devel@nongnu.org; Wed, 18 Sep 2013 10:29:20 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:52996) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VMIki-0000Yn-LI for qemu-devel@nongnu.org; Wed, 18 Sep 2013 10:29:12 -0400 Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 18 Sep 2013 08:29:11 -0600 Received: from d03relay05.boulder.ibm.com (d03relay05.boulder.ibm.com [9.17.195.107]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id 024E01FF001F for ; Wed, 18 Sep 2013 08:29:02 -0600 (MDT) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay05.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r8IESqaQ152100 for ; Wed, 18 Sep 2013 08:28:56 -0600 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r8IESqfs017083 for ; Wed, 18 Sep 2013 08:28:52 -0600 Message-ID: <5239B8A3.10305@linux.vnet.ibm.com> Date: Wed, 18 Sep 2013 10:28:51 -0400 From: "Michael R. Hines" MIME-Version: 1.0 References: <5d53d839653bf4fd24d5cb56f6d24d3dc3f8f8a5.1378261891.git.yamahata@private.email.ne.jp> In-Reply-To: <5d53d839653bf4fd24d5cb56f6d24d3dc3f8f8a5.1378261891.git.yamahata@private.email.ne.jp> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] rdma: constify ram_chunk_{index, start, end} List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaku Yamahata Cc: owasserm@redhat.com, quintela@redhat.com, mrhines@us.ibm.com, qemu-devel@nongnu.org, pbonzini@redhat.com On 09/03/2013 10:32 PM, Isaku Yamahata wrote: > Signed-off-by: Isaku Yamahata > --- > migration-rdma.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/migration-rdma.c b/migration-rdma.c > index e71c10a..db5a908 100644 > --- a/migration-rdma.c > +++ b/migration-rdma.c > @@ -511,19 +511,21 @@ static int qemu_rdma_exchange_send(RDMAContext *rdma, RDMAControlHeader *head, > int *resp_idx, > int (*callback)(RDMAContext *rdma)); > > -static inline uint64_t ram_chunk_index(uint8_t *start, uint8_t *host) > +static inline uint64_t ram_chunk_index(const uint8_t *start, > + const uint8_t *host) > { > return ((uintptr_t) host - (uintptr_t) start) >> RDMA_REG_CHUNK_SHIFT; > } > > -static inline uint8_t *ram_chunk_start(RDMALocalBlock *rdma_ram_block, > +static inline uint8_t *ram_chunk_start(const RDMALocalBlock *rdma_ram_block, > uint64_t i) > { > return (uint8_t *) (((uintptr_t) rdma_ram_block->local_host_addr) > + (i << RDMA_REG_CHUNK_SHIFT)); > } > > -static inline uint8_t *ram_chunk_end(RDMALocalBlock *rdma_ram_block, uint64_t i) > +static inline uint8_t *ram_chunk_end(const RDMALocalBlock *rdma_ram_block, > + uint64_t i) > { > uint8_t *result = ram_chunk_start(rdma_ram_block, i) + > (1UL << RDMA_REG_CHUNK_SHIFT); Isaku, you are sending lots of "little" patches which may or may not be properly rebased upon previous patches. Could you please group your current patch series into a single series with a descriptive cover letter along with the previous patches? If you need create a new patch specifically for RDMA before a previous patch as been applied to my tree, then please include the old one into the new patch series with a description and a "resend" in the title. Then I can review them at once apply them all to my tree so the maintaner has an easier time. Thanks, - Michael